Allow base override with --with-base-lang= parameter - #335
Conversation
| $langs[] = $lang; | ||
| if ( $arg == '--chmonly' ) | ||
| { | ||
| $chmonly = true; |
There was a problem hiding this comment.
Added this because it was a stale variable.
There was a problem hiding this comment.
This variable can be removed, and --chmonly skiped as legacy parameter. This script now always generate all paths.
| $langOne3 = dtd_pe_body( __DIR__ . "/../$base/extensions.ent" ); | ||
|
|
||
| if ( $lang == 'en ' ) | ||
| if ( lang_is_base() ) |
There was a problem hiding this comment.
The previous line was a bug. It contained an extra space.
|
The objective is building doc-ext with For first building doc-ext, that only exists in English, cloning the doc-ext/doc-contrib as In general I'm trying to remove the options of configure.php. I was about to remove xpointer-reporting and some other cases. Also, I was normalizing code paths to consider building a "single language" versus "double languages" (aka, base overlay + translation overlay) as text-entities.php does now, by accepting up to two language arguments, in overwriting order. But configure.php has a long history of building doc-en as Then, the suggestion would be renaming --standalone to something like --with-single-lang=, so codepath that forces configure into building a single language that is not a
That will make condigure.php align with text-entities.php (and unlike some other sub parts). |
And how do you see this from a server or local perspective where both doc-en and doc-extensions need to be? Locally docker may be the solution, but I like the ability to just run configure.php myself when required.
Technically doc-en is standalone in its sense that it doesn't depend on any other language. What if we rename |
I was only considering the building of each one, separately. As they need to be fully independent, they do not need to exist side by side at any moment. And yes, not changing the Note, whorever, that "en" as output is not really a problem, AFAIK the actual building of manuals resuses doc-base and PhD output dirs, collecting the generated artifacts after the end of each language.
That would be very ok, as this align the base-as-single pattern of actual configure. |
|
Feedback has been handled. Please let me know what you think. |
Adds a
--standaloneconfigure option that treats the language directory as a complete, authoritative manual tree instead of a translation overlay ofen.This continues the third-party manual work from #324. And is required for building doc-extensions, without forcing the in/output to
en.