Optimize CI caching and metrics flush - #265
Open
YanagiKH wants to merge 1 commit into
Open
Conversation
- Add Rust cache to the package test workflow to reduce repeated build time. - Replace the SQLite metrics drain/collect path with `std::mem::take` to avoid an extra allocation when flushing buffered telemetry.
jordandunmire97-ai
approved these changes
Aug 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
This change reduces repeated CI build time and removes an avoidable allocation in a hot telemetry flush path.
std::mem::takewhen flushing the buffered samples, which avoids draining into a newly allocated vector.How this change came about
I reviewed the package test workflow and the SQLite telemetry exporter, then made two focused changes:
.github/workflows/package_test.ymlto reduce repeated build work in CI.drain(..).collect()withstd::mem::takeinsrc/engine/telemetry/exporter.rsto avoid an extra allocation while flushing buffered telemetry.I made the edits directly in the repository and kept the scope limited to the two files above.
How has this been tested?
I verified the change by code inspection. No additional runtime test was run in this session.
Types of changes
Checklist: