CCXDEV-16677: Fix format and clippy warnings by slashpai · Pull Request #90 · openshift/insights-runtime-extractor

slashpai · 2026-08-11T13:58:42Z

Before changes:

─ make rust-dev                                                                                             ─╯
./scripts/rust-dev.sh
[root@042a0692d21e extractor]# make clippy
cargo clippy -- -D warnings
    Checking insights-runtime-extractor v0.1.0 (/opt/app-root/src/insights-runtime-extractor/extractor)
error: unneeded `return` statement
  --> src/insights_runtime_extractor/container.rs:76:5
   |
76 |     return containers;
   |     ^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#needless_return
   = note: `-D clippy::needless-return` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(clippy::needless_return)]`
help: remove `return`
   |
76 -     return containers;
76 +     containers
   |

error: unneeded `return` statement
  --> src/insights_runtime_extractor/container.rs:97:5
   |
97 |     return pid;
   |     ^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#needless_return
help: remove `return`
   |
97 -     return pid;
97 +     pid
   |

error: writing `&String` instead of `&str` involves a new object where a slice will do
  --> src/insights_runtime_extractor/container.rs:79:35
   |
79 | pub fn get_root_pid(container_id: &String) -> u32 {
   |                                   ^^^^^^^ help: change this to: `&str`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#ptr_arg
   = note: `-D clippy::ptr-arg` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(clippy::ptr_arg)]`

error: the borrowed expression implements the required traits
  --> src/insights_runtime_extractor/file.rs:15:40
   |
15 |     if let Err(e) = fs::remove_dir_all(&name) {
   |                                        ^^^^^ help: change this to: `name`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#needless_borrows_for_generic_args
   = note: `-D clippy::needless-borrows-for-generic-args` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(clippy::needless_borrows_for_generic_args)]`

error: the borrowed expression implements the required traits
  --> src/insights_runtime_extractor/file.rs:21:25
   |
21 |     fs::set_permissions(&name, fs::Permissions::from_mode(0o777))?;
   |                         ^^^^^ help: change this to: `name`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#needless_borrows_for_generic_args

error: the borrowed expression implements the required traits
  --> src/insights_runtime_extractor/file.rs:23:16
   |
23 |     File::open(&name)
   |                ^^^^^ help: change this to: `name`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#needless_borrows_for_generic_args

error: length comparison to zero
  --> src/insights_runtime_extractor/file.rs:53:8
   |
53 |     if entries.len() == 0 {
   |        ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `entries.is_empty()`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#len_zero
   = note: `-D clippy::len-zero` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(clippy::len_zero)]`

error: unneeded `return` statement
  --> src/insights_runtime_extractor/fingerprint/java.rs:34:9
   |
34 | /         return process
35 | |             .command_line
36 | |             .iter()
37 | |             .position(|s| s.starts_with("-Djboss.home.dir"))
...  |
50 | |                 ])
51 | |             });
   | |______________^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#needless_return
help: remove `return`
   |
34 ~         process
35 +             .command_line
36 +             .iter()
37 +             .position(|s| s.starts_with("-Djboss.home.dir"))
38 +             .and_then(|i| process.command_line.get(i))
39 +             .and_then(|jboss_home_dir_sys_prop| jboss_home_dir_sys_prop.split_once("="))
40 +             .and_then(|(_, jboss_home_dir)| {
41 +                 debug!(
42 +                     "Process {} is using JBoss Module from JBoss Home {:#?}",
43 +                     &process.pid, jboss_home_dir
44 +                 );
45 + 
46 +                 Some(vec![
47 +                     String::from("./fpr_java_jboss_modules"),
48 +                     out_dir.to_string(),
49 +                     jboss_home_dir.to_string(),
50 +                 ])
51 ~             })
   |

error: using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)`
  --> src/insights_runtime_extractor/fingerprint/java.rs:34:16
   |
34 |           return process
   |  ________________^
35 | |             .command_line
36 | |             .iter()
37 | |             .position(|s| s.starts_with("-Djboss.home.dir"))
...  |
50 | |                 ])
51 | |             });
   | |______________^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#bind_instead_of_map
   = note: `-D clippy::bind-instead-of-map` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(clippy::bind_instead_of_map)]`
help: use `map` instead
   |
40 ~             .map(|(_, jboss_home_dir)| {
41 |                 debug!(
...
45 |
46 ~                 vec![
47 +                     String::from("./fpr_java_jboss_modules"),
48 +                     out_dir.to_string(),
49 +                     jboss_home_dir.to_string(),
50 +                 ]
   |

error: unneeded `return` statement
  --> src/insights_runtime_extractor/fingerprint/java.rs:64:9
   |
64 | /         return Some(vec![
65 | |             String::from("./fpr_java_runtimes"),
66 | |             out_dir.to_string(),
67 | |             jar.to_string(),
68 | |         ]);
   | |__________^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#needless_return
help: remove `return`
   |
64 ~         Some(vec![
65 +             String::from("./fpr_java_runtimes"),
66 +             out_dir.to_string(),
67 +             jar.to_string(),
68 ~         ])
   |

error: unneeded `return` statement
  --> src/insights_runtime_extractor/fingerprint/java.rs:94:21
   |
94 |                     return Java::jboss_modules_executable(&out_dir, process);
   |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#needless_return
help: remove `return`
   |
94 -                     return Java::jboss_modules_executable(&out_dir, process);
94 +                     Java::jboss_modules_executable(&out_dir, process)
   |

error: unneeded `return` statement
  --> src/insights_runtime_extractor/fingerprint/java.rs:96:21
   |
96 |                     return Java::jar_executable(&out_dir, process, jar);
   |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#needless_return
help: remove `return`
   |
96 -                     return Java::jar_executable(&out_dir, process, jar);
96 +                     Java::jar_executable(&out_dir, process, jar)
   |

error: this expression creates a reference which is immediately dereferenced by the compiler
  --> src/insights_runtime_extractor/fingerprint/java.rs:94:59
   |
94 |                     return Java::jboss_modules_executable(&out_dir, process);
   |                                                           ^^^^^^^^ help: change this to: `out_dir`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#needless_borrow
   = note: `-D clippy::needless-borrow` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(clippy::needless_borrow)]`

error: this expression creates a reference which is immediately dereferenced by the compiler
  --> src/insights_runtime_extractor/fingerprint/java.rs:96:49
   |
96 |                     return Java::jar_executable(&out_dir, process, jar);
   |                                                 ^^^^^^^^ help: change this to: `out_dir`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#needless_borrow

error: unneeded `return` statement
   --> src/insights_runtime_extractor/fingerprint/java.rs:126:45
    |
126 | ...                   .and_then(|jar| return Java::jar_executable(&out_dir, process, &jar));
    |                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#needless_return
help: remove `return`
    |
126 -                             .and_then(|jar| return Java::jar_executable(&out_dir, process, &jar));
126 +                             .and_then(|jar| Java::jar_executable(&out_dir, process, &jar));
    |

error: this expression creates a reference which is immediately dereferenced by the compiler
   --> src/insights_runtime_extractor/fingerprint/java.rs:126:73
    |
126 | ...                   .and_then(|jar| return Java::jar_executable(&out_dir, process, &jar));
    |                                                                   ^^^^^^^^ help: change this to: `out_dir`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#needless_borrow

error: this expression creates a reference which is immediately dereferenced by the compiler
   --> src/insights_runtime_extractor/fingerprint/java.rs:126:92
    |
126 | ...                   .and_then(|jar| return Java::jar_executable(&out_dir, process, &jar));
    |                                                                                      ^^^^ help: change this to: `jar`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#needless_borrow

error: useless conversion to the same type: `std::option::Option<std::vec::Vec<std::string::String>>`
   --> src/insights_runtime_extractor/fingerprint/java.rs:128:36
    |
128 | ...                   return found.into();
    |                              ^^^^^^^^^^^^ help: consider removing `.into()`: `found`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#useless_conversion
    = note: `-D clippy::useless-conversion` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::useless_conversion)]`

error: this expression creates a reference which is immediately dereferenced by the compiler
  --> src/insights_runtime_extractor/fingerprint/native_executable.rs:26:41
   |
26 |         match version_exec.can_apply_to(&config, &out_dir, &process) {
   |                                         ^^^^^^^ help: change this to: `config`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#needless_borrow

error: this expression creates a reference which is immediately dereferenced by the compiler
  --> src/insights_runtime_extractor/fingerprint/native_executable.rs:26:50
   |
26 |         match version_exec.can_apply_to(&config, &out_dir, &process) {
   |                                                  ^^^^^^^^ help: change this to: `out_dir`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#needless_borrow

error: this expression creates a reference which is immediately dereferenced by the compiler
  --> src/insights_runtime_extractor/fingerprint/native_executable.rs:26:60
   |
26 |         match version_exec.can_apply_to(&config, &out_dir, &process) {
   |                                                            ^^^^^^^^ help: change this to: `process`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#needless_borrow

error: accessing first element with `process.command_line.get(0)`
  --> src/insights_runtime_extractor/fingerprint/native_executable.rs:32:17
   |
32 |                 process.command_line.get(0)?.clone(),
   |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `process.command_line.first()`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#get_first
   = note: `-D clippy::get-first` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(clippy::get_first)]`

error: writing `&String` instead of `&str` involves a new object where a slice will do
  --> src/insights_runtime_extractor/fingerprint.rs:16:18
   |
16 |         out_dir: &String,
   |                  ^^^^^^^ help: change this to: `&str`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#ptr_arg

error: this expression creates a reference which is immediately dereferenced by the compiler
  --> src/insights_runtime_extractor/fingerprint.rs:34:62
   |
34 |         if let Some(exec) = fingerprint.can_apply_to(config, &out_dir, &process) {
   |                                                              ^^^^^^^^ help: change this to: `out_dir`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#needless_borrow

error: this expression creates a reference which is immediately dereferenced by the compiler
  --> src/insights_runtime_extractor/fingerprint.rs:34:72
   |
34 |         if let Some(exec) = fingerprint.can_apply_to(config, &out_dir, &process) {
   |                                                                        ^^^^^^^^ help: change this to: `process`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#needless_borrow

error: the borrowed expression implements the required traits
  --> src/insights_runtime_extractor/fingerprint.rs:37:44
   |
37 |                 let command = Command::new(&command).args(args).output();
   |                                            ^^^^^^^^ help: change this to: `command`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#needless_borrows_for_generic_args

error: this expression creates a reference which is immediately dereferenced by the compiler
  --> src/insights_runtime_extractor/process.rs:22:29
   |
22 |     let leaves = get_leaves(&pid);
   |                             ^^^^ help: change this to: `pid`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#needless_borrow

error: called `map(..).flatten()` on `Iterator`
  --> src/insights_runtime_extractor/process.rs:27:10
   |
27 |           .map(|pid| s.process(Pid::from_u32(*pid)))
   |  __________^
28 | |         .flatten()
   | |__________________^ help: try replacing `map` with `filter_map` and remove the `.flatten()`: `filter_map(|pid| s.process(Pid::from_u32(*pid)))`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#map_flatten
   = note: `-D clippy::map-flatten` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(clippy::map_flatten)]`

error: using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)`
  --> src/insights_runtime_extractor/process.rs:34:18
   |
34 |               cwd: process
   |  __________________^
35 | |                 .cwd()
36 | |                 .and_then(|p| Some(p.to_string_lossy().into_owned())),
   | |_____________________________________________________________________^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#bind_instead_of_map
help: try
   |
34 ~             cwd: process
35 ~                 .cwd().map(|p| p.to_string_lossy().into_owned()),
   |

error: this expression creates a reference which is immediately dereferenced by the compiler
  --> src/insights_runtime_extractor/process.rs:51:20
   |
51 |     collect_leaves(&root_pid, &mut leaves);
   |                    ^^^^^^^^^ help: change this to: `root_pid`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#needless_borrow

error: length comparison to zero
  --> src/insights_runtime_extractor/process.rs:61:12
   |
61 |         if content.len() == 0 {
   |            ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `content.is_empty()`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#len_zero

error: accessing first element with `leaves.get(0)`
  --> src/insights_runtime_extractor.rs:76:28
   |
76 |     if let Some(process) = leaves.get(0) {
   |                            ^^^^^^^^^^^^^ help: try: `leaves.first()`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#get_first

error: function call inside of `expect`
  --> src/insights_runtime_extractor.rs:81:45
   |
81 |           file::create_dir(&container_output).expect(&format!(
   |  _____________________________________________^
82 | |             "Can not create output directory for container {}",
83 | |             &container.id
84 | |         ));
   | |__________^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#expect_fun_call
   = note: `-D clippy::expect-fun-call` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(clippy::expect_fun_call)]`
help: try
   |
81 ~         file::create_dir(&container_output).unwrap_or_else(|_| panic!("Can not create output directory for container {}",
82 ~             &container.id));
   |

error: called `ok().expect()` on a `Result` value
   --> src/insights_runtime_extractor.rs:100:9
    |
100 | /         fs::copy("/config.toml", container_output.clone() + "/config.toml")
101 | |             .ok()
102 | |             .expect("Copy configuration for fingerprints execution");
    | |____________________________________________________________________^
    |
    = help: you can call `expect()` directly on the `Result`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#ok_expect
    = note: `-D clippy::ok-expect` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::ok_expect)]`

error: this expression creates a reference which is immediately dereferenced by the compiler
   --> src/insights_runtime_extractor.rs:106:31
    |
106 |         let _ = fork_and_exec(&config, &process, &current_dir, &container_output);
    |                               ^^^^^^^ help: change this to: `config`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#needless_borrow

error: this expression creates a reference which is immediately dereferenced by the compiler
   --> src/insights_runtime_extractor.rs:106:40
    |
106 |         let _ = fork_and_exec(&config, &process, &current_dir, &container_output);
    |                                        ^^^^^^^^ help: change this to: `process`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#needless_borrow

error: unneeded `return` statement
   --> src/insights_runtime_extractor.rs:133:13
    |
133 |             return Ok(());
    |             ^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#needless_return
help: remove `return`
    |
133 -             return Ok(());
133 +             Ok(())
    |

error: redundant guard
   --> src/insights_runtime_extractor.rs:126:52
    |
126 |                     WaitStatus::Exited(_, code) if code == 0 => {}
    |                                                    ^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#redundant_guards
    = note: `-D clippy::redundant-guards` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::redundant_guards)]`
help: try
    |
126 -                     WaitStatus::Exited(_, code) if code == 0 => {}
126 +                     WaitStatus::Exited(_, 0) => {}
    |

error: this expression creates a reference which is immediately dereferenced by the compiler
   --> src/insights_runtime_extractor.rs:146:43
    |
146 |             fingerprint::run_fingerprints(&config, out_dir, &process);
    |                                           ^^^^^^^ help: change this to: `config`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#needless_borrow

error: this expression creates a reference which is immediately dereferenced by the compiler
   --> src/insights_runtime_extractor.rs:146:61
    |
146 |             fingerprint::run_fingerprints(&config, out_dir, &process);
    |                                                             ^^^^^^^^ help: change this to: `process`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#needless_borrow

error: function call inside of `expect`
   --> src/insights_runtime_extractor.rs:174:33
    |
174 |         let f = File::open(&ns).expect(&format!("Open namespace file {:?}", &ns));
    |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|_| panic!("Open namespace file {:?}", &ns))`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#expect_fun_call

error: function call inside of `expect`
   --> src/insights_runtime_extractor.rs:176:40
    |
176 |         setns(fd, CloneFlags::empty()).expect(&format!("join namespace {:?}", &ns));
    |                                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|_| panic!("join namespace {:?}", &ns))`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#expect_fun_call

error: redundant closure
   --> src/insights_runtime_extractor.rs:184:33
    |
184 |     seteuid(uid.into()).map_err(|e| ScannerError::Errno(e))
    |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `ScannerError::Errno`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#redundant_closure
    = note: `-D clippy::redundant-closure` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::redundant_closure)]`

error: could not compile `insights-runtime-extractor` (lib) due to 43 previous errors

Signed-off-by: Jayapriya Pai <janantha@redhat.com>

openshift-merge-bot · 2026-08-11T13:58:45Z

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

openshift-ci-robot · 2026-08-11T13:58:46Z

@slashpai: This pull request references CCXDEV-16677 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Before changes:

─ make rust-dev                                                                                             ─╯
./scripts/rust-dev.sh
[root@042a0692d21e extractor]# make clippy
cargo clippy -- -D warnings
   Checking insights-runtime-extractor v0.1.0 (/opt/app-root/src/insights-runtime-extractor/extractor)
error: unneeded `return` statement
 --> src/insights_runtime_extractor/container.rs:76:5
  |
76 |     return containers;
  |     ^^^^^^^^^^^^^^^^^
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#needless_return
  = note: `-D clippy::needless-return` implied by `-D warnings`
  = help: to override `-D warnings` add `#[allow(clippy::needless_return)]`
help: remove `return`
  |
76 -     return containers;
76 +     containers
  |

error: unneeded `return` statement
 --> src/insights_runtime_extractor/container.rs:97:5
  |
97 |     return pid;
  |     ^^^^^^^^^^
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#needless_return
help: remove `return`
  |
97 -     return pid;
97 +     pid
  |

error: writing `&String` instead of `&str` involves a new object where a slice will do
 --> src/insights_runtime_extractor/container.rs:79:35
  |
79 | pub fn get_root_pid(container_id: &String) -> u32 {
  |                                   ^^^^^^^ help: change this to: `&str`
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#ptr_arg
  = note: `-D clippy::ptr-arg` implied by `-D warnings`
  = help: to override `-D warnings` add `#[allow(clippy::ptr_arg)]`

error: the borrowed expression implements the required traits
 --> src/insights_runtime_extractor/file.rs:15:40
  |
15 |     if let Err(e) = fs::remove_dir_all(&name) {
  |                                        ^^^^^ help: change this to: `name`
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#needless_borrows_for_generic_args
  = note: `-D clippy::needless-borrows-for-generic-args` implied by `-D warnings`
  = help: to override `-D warnings` add `#[allow(clippy::needless_borrows_for_generic_args)]`

error: the borrowed expression implements the required traits
 --> src/insights_runtime_extractor/file.rs:21:25
  |
21 |     fs::set_permissions(&name, fs::Permissions::from_mode(0o777))?;
  |                         ^^^^^ help: change this to: `name`
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#needless_borrows_for_generic_args

error: the borrowed expression implements the required traits
 --> src/insights_runtime_extractor/file.rs:23:16
  |
23 |     File::open(&name)
  |                ^^^^^ help: change this to: `name`
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#needless_borrows_for_generic_args

error: length comparison to zero
 --> src/insights_runtime_extractor/file.rs:53:8
  |
53 |     if entries.len() == 0 {
  |        ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `entries.is_empty()`
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#len_zero
  = note: `-D clippy::len-zero` implied by `-D warnings`
  = help: to override `-D warnings` add `#[allow(clippy::len_zero)]`

error: unneeded `return` statement
 --> src/insights_runtime_extractor/fingerprint/java.rs:34:9
  |
34 | /         return process
35 | |             .command_line
36 | |             .iter()
37 | |             .position(|s| s.starts_with("-Djboss.home.dir"))
...  |
50 | |                 ])
51 | |             });
  | |______________^
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#needless_return
help: remove `return`
  |
34 ~         process
35 +             .command_line
36 +             .iter()
37 +             .position(|s| s.starts_with("-Djboss.home.dir"))
38 +             .and_then(|i| process.command_line.get(i))
39 +             .and_then(|jboss_home_dir_sys_prop| jboss_home_dir_sys_prop.split_once("="))
40 +             .and_then(|(_, jboss_home_dir)| {
41 +                 debug!(
42 +                     "Process {} is using JBoss Module from JBoss Home {:#?}",
43 +                     &process.pid, jboss_home_dir
44 +                 );
45 + 
46 +                 Some(vec![
47 +                     String::from("./fpr_java_jboss_modules"),
48 +                     out_dir.to_string(),
49 +                     jboss_home_dir.to_string(),
50 +                 ])
51 ~             })
  |

error: using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)`
 --> src/insights_runtime_extractor/fingerprint/java.rs:34:16
  |
34 |           return process
  |  ________________^
35 | |             .command_line
36 | |             .iter()
37 | |             .position(|s| s.starts_with("-Djboss.home.dir"))
...  |
50 | |                 ])
51 | |             });
  | |______________^
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#bind_instead_of_map
  = note: `-D clippy::bind-instead-of-map` implied by `-D warnings`
  = help: to override `-D warnings` add `#[allow(clippy::bind_instead_of_map)]`
help: use `map` instead
  |
40 ~             .map(|(_, jboss_home_dir)| {
41 |                 debug!(
...
45 |
46 ~                 vec![
47 +                     String::from("./fpr_java_jboss_modules"),
48 +                     out_dir.to_string(),
49 +                     jboss_home_dir.to_string(),
50 +                 ]
  |

error: unneeded `return` statement
 --> src/insights_runtime_extractor/fingerprint/java.rs:64:9
  |
64 | /         return Some(vec![
65 | |             String::from("./fpr_java_runtimes"),
66 | |             out_dir.to_string(),
67 | |             jar.to_string(),
68 | |         ]);
  | |__________^
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#needless_return
help: remove `return`
  |
64 ~         Some(vec![
65 +             String::from("./fpr_java_runtimes"),
66 +             out_dir.to_string(),
67 +             jar.to_string(),
68 ~         ])
  |

error: unneeded `return` statement
 --> src/insights_runtime_extractor/fingerprint/java.rs:94:21
  |
94 |                     return Java::jboss_modules_executable(&out_dir, process);
  |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#needless_return
help: remove `return`
  |
94 -                     return Java::jboss_modules_executable(&out_dir, process);
94 +                     Java::jboss_modules_executable(&out_dir, process)
  |

error: unneeded `return` statement
 --> src/insights_runtime_extractor/fingerprint/java.rs:96:21
  |
96 |                     return Java::jar_executable(&out_dir, process, jar);
  |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#needless_return
help: remove `return`
  |
96 -                     return Java::jar_executable(&out_dir, process, jar);
96 +                     Java::jar_executable(&out_dir, process, jar)
  |

error: this expression creates a reference which is immediately dereferenced by the compiler
 --> src/insights_runtime_extractor/fingerprint/java.rs:94:59
  |
94 |                     return Java::jboss_modules_executable(&out_dir, process);
  |                                                           ^^^^^^^^ help: change this to: `out_dir`
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#needless_borrow
  = note: `-D clippy::needless-borrow` implied by `-D warnings`
  = help: to override `-D warnings` add `#[allow(clippy::needless_borrow)]`

error: this expression creates a reference which is immediately dereferenced by the compiler
 --> src/insights_runtime_extractor/fingerprint/java.rs:96:49
  |
96 |                     return Java::jar_executable(&out_dir, process, jar);
  |                                                 ^^^^^^^^ help: change this to: `out_dir`
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#needless_borrow

error: unneeded `return` statement
  --> src/insights_runtime_extractor/fingerprint/java.rs:126:45
   |
126 | ...                   .and_then(|jar| return Java::jar_executable(&out_dir, process, &jar));
   |                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#needless_return
help: remove `return`
   |
126 -                             .and_then(|jar| return Java::jar_executable(&out_dir, process, &jar));
126 +                             .and_then(|jar| Java::jar_executable(&out_dir, process, &jar));
   |

error: this expression creates a reference which is immediately dereferenced by the compiler
  --> src/insights_runtime_extractor/fingerprint/java.rs:126:73
   |
126 | ...                   .and_then(|jar| return Java::jar_executable(&out_dir, process, &jar));
   |                                                                   ^^^^^^^^ help: change this to: `out_dir`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#needless_borrow

error: this expression creates a reference which is immediately dereferenced by the compiler
  --> src/insights_runtime_extractor/fingerprint/java.rs:126:92
   |
126 | ...                   .and_then(|jar| return Java::jar_executable(&out_dir, process, &jar));
   |                                                                                      ^^^^ help: change this to: `jar`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#needless_borrow

error: useless conversion to the same type: `std::option::Option<std::vec::Vec<std::string::String>>`
  --> src/insights_runtime_extractor/fingerprint/java.rs:128:36
   |
128 | ...                   return found.into();
   |                              ^^^^^^^^^^^^ help: consider removing `.into()`: `found`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#useless_conversion
   = note: `-D clippy::useless-conversion` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(clippy::useless_conversion)]`

error: this expression creates a reference which is immediately dereferenced by the compiler
 --> src/insights_runtime_extractor/fingerprint/native_executable.rs:26:41
  |
26 |         match version_exec.can_apply_to(&config, &out_dir, &process) {
  |                                         ^^^^^^^ help: change this to: `config`
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#needless_borrow

error: this expression creates a reference which is immediately dereferenced by the compiler
 --> src/insights_runtime_extractor/fingerprint/native_executable.rs:26:50
  |
26 |         match version_exec.can_apply_to(&config, &out_dir, &process) {
  |                                                  ^^^^^^^^ help: change this to: `out_dir`
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#needless_borrow

error: this expression creates a reference which is immediately dereferenced by the compiler
 --> src/insights_runtime_extractor/fingerprint/native_executable.rs:26:60
  |
26 |         match version_exec.can_apply_to(&config, &out_dir, &process) {
  |                                                            ^^^^^^^^ help: change this to: `process`
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#needless_borrow

error: accessing first element with `process.command_line.get(0)`
 --> src/insights_runtime_extractor/fingerprint/native_executable.rs:32:17
  |
32 |                 process.command_line.get(0)?.clone(),
  |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `process.command_line.first()`
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#get_first
  = note: `-D clippy::get-first` implied by `-D warnings`
  = help: to override `-D warnings` add `#[allow(clippy::get_first)]`

error: writing `&String` instead of `&str` involves a new object where a slice will do
 --> src/insights_runtime_extractor/fingerprint.rs:16:18
  |
16 |         out_dir: &String,
  |                  ^^^^^^^ help: change this to: `&str`
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#ptr_arg

error: this expression creates a reference which is immediately dereferenced by the compiler
 --> src/insights_runtime_extractor/fingerprint.rs:34:62
  |
34 |         if let Some(exec) = fingerprint.can_apply_to(config, &out_dir, &process) {
  |                                                              ^^^^^^^^ help: change this to: `out_dir`
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#needless_borrow

error: this expression creates a reference which is immediately dereferenced by the compiler
 --> src/insights_runtime_extractor/fingerprint.rs:34:72
  |
34 |         if let Some(exec) = fingerprint.can_apply_to(config, &out_dir, &process) {
  |                                                                        ^^^^^^^^ help: change this to: `process`
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#needless_borrow

error: the borrowed expression implements the required traits
 --> src/insights_runtime_extractor/fingerprint.rs:37:44
  |
37 |                 let command = Command::new(&command).args(args).output();
  |                                            ^^^^^^^^ help: change this to: `command`
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#needless_borrows_for_generic_args

error: this expression creates a reference which is immediately dereferenced by the compiler
 --> src/insights_runtime_extractor/process.rs:22:29
  |
22 |     let leaves = get_leaves(&pid);
  |                             ^^^^ help: change this to: `pid`
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#needless_borrow

error: called `map(..).flatten()` on `Iterator`
 --> src/insights_runtime_extractor/process.rs:27:10
  |
27 |           .map(|pid| s.process(Pid::from_u32(*pid)))
  |  __________^
28 | |         .flatten()
  | |__________________^ help: try replacing `map` with `filter_map` and remove the `.flatten()`: `filter_map(|pid| s.process(Pid::from_u32(*pid)))`
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#map_flatten
  = note: `-D clippy::map-flatten` implied by `-D warnings`
  = help: to override `-D warnings` add `#[allow(clippy::map_flatten)]`

error: using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)`
 --> src/insights_runtime_extractor/process.rs:34:18
  |
34 |               cwd: process
  |  __________________^
35 | |                 .cwd()
36 | |                 .and_then(|p| Some(p.to_string_lossy().into_owned())),
  | |_____________________________________________________________________^
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#bind_instead_of_map
help: try
  |
34 ~             cwd: process
35 ~                 .cwd().map(|p| p.to_string_lossy().into_owned()),
  |

error: this expression creates a reference which is immediately dereferenced by the compiler
 --> src/insights_runtime_extractor/process.rs:51:20
  |
51 |     collect_leaves(&root_pid, &mut leaves);
  |                    ^^^^^^^^^ help: change this to: `root_pid`
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#needless_borrow

error: length comparison to zero
 --> src/insights_runtime_extractor/process.rs:61:12
  |
61 |         if content.len() == 0 {
  |            ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `content.is_empty()`
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#len_zero

error: accessing first element with `leaves.get(0)`
 --> src/insights_runtime_extractor.rs:76:28
  |
76 |     if let Some(process) = leaves.get(0) {
  |                            ^^^^^^^^^^^^^ help: try: `leaves.first()`
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#get_first

error: function call inside of `expect`
 --> src/insights_runtime_extractor.rs:81:45
  |
81 |           file::create_dir(&container_output).expect(&format!(
  |  _____________________________________________^
82 | |             "Can not create output directory for container {}",
83 | |             &container.id
84 | |         ));
  | |__________^
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#expect_fun_call
  = note: `-D clippy::expect-fun-call` implied by `-D warnings`
  = help: to override `-D warnings` add `#[allow(clippy::expect_fun_call)]`
help: try
  |
81 ~         file::create_dir(&container_output).unwrap_or_else(|_| panic!("Can not create output directory for container {}",
82 ~             &container.id));
  |

error: called `ok().expect()` on a `Result` value
  --> src/insights_runtime_extractor.rs:100:9
   |
100 | /         fs::copy("/config.toml", container_output.clone() + "/config.toml")
101 | |             .ok()
102 | |             .expect("Copy configuration for fingerprints execution");
   | |____________________________________________________________________^
   |
   = help: you can call `expect()` directly on the `Result`
   = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#ok_expect
   = note: `-D clippy::ok-expect` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(clippy::ok_expect)]`

error: this expression creates a reference which is immediately dereferenced by the compiler
  --> src/insights_runtime_extractor.rs:106:31
   |
106 |         let _ = fork_and_exec(&config, &process, &current_dir, &container_output);
   |                               ^^^^^^^ help: change this to: `config`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#needless_borrow

error: this expression creates a reference which is immediately dereferenced by the compiler
  --> src/insights_runtime_extractor.rs:106:40
   |
106 |         let _ = fork_and_exec(&config, &process, &current_dir, &container_output);
   |                                        ^^^^^^^^ help: change this to: `process`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#needless_borrow

error: unneeded `return` statement
  --> src/insights_runtime_extractor.rs:133:13
   |
133 |             return Ok(());
   |             ^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#needless_return
help: remove `return`
   |
133 -             return Ok(());
133 +             Ok(())
   |

error: redundant guard
  --> src/insights_runtime_extractor.rs:126:52
   |
126 |                     WaitStatus::Exited(_, code) if code == 0 => {}
   |                                                    ^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#redundant_guards
   = note: `-D clippy::redundant-guards` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(clippy::redundant_guards)]`
help: try
   |
126 -                     WaitStatus::Exited(_, code) if code == 0 => {}
126 +                     WaitStatus::Exited(_, 0) => {}
   |

error: this expression creates a reference which is immediately dereferenced by the compiler
  --> src/insights_runtime_extractor.rs:146:43
   |
146 |             fingerprint::run_fingerprints(&config, out_dir, &process);
   |                                           ^^^^^^^ help: change this to: `config`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#needless_borrow

error: this expression creates a reference which is immediately dereferenced by the compiler
  --> src/insights_runtime_extractor.rs:146:61
   |
146 |             fingerprint::run_fingerprints(&config, out_dir, &process);
   |                                                             ^^^^^^^^ help: change this to: `process`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#needless_borrow

error: function call inside of `expect`
  --> src/insights_runtime_extractor.rs:174:33
   |
174 |         let f = File::open(&ns).expect(&format!("Open namespace file {:?}", &ns));
   |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|_| panic!("Open namespace file {:?}", &ns))`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#expect_fun_call

error: function call inside of `expect`
  --> src/insights_runtime_extractor.rs:176:40
   |
176 |         setns(fd, CloneFlags::empty()).expect(&format!("join namespace {:?}", &ns));
   |                                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|_| panic!("join namespace {:?}", &ns))`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#expect_fun_call

error: redundant closure
  --> src/insights_runtime_extractor.rs:184:33
   |
184 |     seteuid(uid.into()).map_err(|e| ScannerError::Errno(e))
   |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `ScannerError::Errno`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#redundant_closure
   = note: `-D clippy::redundant-closure` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(clippy::redundant_closure)]`

error: could not compile `insights-runtime-extractor` (lib) due to 43 previous errors

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2026-08-11T13:59:46Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: slashpai
Once this PR has been reviewed and has the lgtm label, please assign jmesnil for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

slashpai · 2026-08-11T14:11:49Z

+    fn jboss_modules_executable(out_dir: &str, process: &ContainerProcess) -> Option<Vec<String>> {
        debug!(
            "Process {} is using JBoss Modules with command line {:#?}",
-            &process.pid, &process.command_line


This and similar warnings fixed are from clippy::needless_borrow https://rust-lang.github.io/rust-clippy/master/index.html#/needless_borrow

slashpai · 2026-08-11T14:12:27Z

cc: @jmesnil for review and feedback

openshift-ci · 2026-08-11T14:19:37Z

@slashpai: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

slashpai added 5 commits August 11, 2026 19:01

build: install clippy in rust-dev image

fe3921f

Signed-off-by: Jayapriya Pai <janantha@redhat.com>

fix: apply clippy suggestions in extractor

ffb73d3

Signed-off-by: Jayapriya Pai <janantha@redhat.com>

fix: format code to pass rustfmt check

f57cd7e

Signed-off-by: Jayapriya Pai <janantha@redhat.com>

build: add clippy auto-fix targets to Makefile

ce34ae1

Signed-off-by: Jayapriya Pai <janantha@redhat.com>

docs: add Rust lint guidelines to STYLEGUIDE.md

00b1b18

Signed-off-by: Jayapriya Pai <janantha@redhat.com>

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 11, 2026

openshift-ci Bot requested review from IshwarKanse and opokornyy August 11, 2026 13:59

slashpai commented Aug 11, 2026

View reviewed changes

Navigation Menu

Uh oh!

CCXDEV-16677: Fix format and clippy warnings - #90

CCXDEV-16677: Fix format and clippy warnings#90
slashpai wants to merge 5 commits into
openshift:mainfrom
slashpai:fix/clippy-warnings

slashpai commented Aug 11, 2026

Uh oh!

openshift-merge-bot Bot commented Aug 11, 2026

Uh oh!

openshift-ci-robot commented Aug 11, 2026 •

edited by openshift-ci Bot

Loading

Uh oh!

openshift-ci Bot commented Aug 11, 2026

Uh oh!

slashpai Aug 11, 2026

Uh oh!

slashpai commented Aug 11, 2026

Uh oh!

openshift-ci Bot commented Aug 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

slashpai commented Aug 11, 2026

Uh oh!

openshift-merge-bot Bot commented Aug 11, 2026

Uh oh!

openshift-ci-robot commented Aug 11, 2026 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci Bot commented Aug 11, 2026

Uh oh!

slashpai Aug 11, 2026

Choose a reason for hiding this comment

Uh oh!

slashpai commented Aug 11, 2026

Uh oh!

openshift-ci Bot commented Aug 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

openshift-ci-robot commented Aug 11, 2026 •

edited by openshift-ci Bot

Loading