Skip to content

OCPBUGS:105601: Fix output directories collision. - #89

Open
jmesnil wants to merge 1 commit into
openshift:mainfrom
jmesnil:OCPBUGS-105601_output_dirs
Open

OCPBUGS:105601: Fix output directories collision.#89
jmesnil wants to merge 1 commit into
openshift:mainfrom
jmesnil:OCPBUGS-105601_output_dirs

Conversation

@jmesnil

@jmesnil jmesnil commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Output directories were created with 0o777 permissions and named using only subsec_nanos (0–999999999), risking collisions when two scans start in the same fractional second.

  • Add mode parameter to create_dir with named constants (SCAN_DIR_MODE 0o700, CONTAINER_DIR_MODE 0o770) instead of hardcoded 0o777
  • Use as_nanos() (full u128 timestamp) instead of subsec_nanos() for the scan directory name
  • chown per-container output dirs to the target UID so the child process can still write after seteuid

JIRA: https://redhat.atlassian.net/browse/OCPBUGS-105601

Output directories were created with 0o777 permissions and named using
only subsec_nanos (0–999999999), risking collisions when two scans
start in the same fractional second.

- Add mode parameter to create_dir with named constants (SCAN_DIR_MODE
  0o700, CONTAINER_DIR_MODE 0o770) instead of hardcoded 0o777
- Use as_nanos() (full u128 timestamp) instead of subsec_nanos() for
  the scan directory name
- chown per-container output dirs to the target UID so the child
  process can still write after seteuid

JIRA: https://redhat.atlassian.net/browse/OCPBUGS-105601

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci

openshift-ci Bot commented Aug 11, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmesnil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 11, 2026
@openshift-ci

openshift-ci Bot commented Aug 11, 2026

Copy link
Copy Markdown

@jmesnil: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant