Add bulk account roles support to AWS connections - #2443
Open
ravikiranvm wants to merge 6 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a bulk-add UX for AWS connection role entries in the React UI (paste account IDs + shared role name/external ID) and updates AWS auth validation to aggregate and report all role assumption failures instead of stopping at the first error. This improves usability for large multi-account AWS connections while keeping the underlying roles[] model intact.
Changes:
- React UI: introduce “Add multiple accounts” flow for AWS connection roles, plus supporting parsing utilities and translations.
- React UI: add an
ArrayBlockPropertyfooter slot (extraActions) and threadarrayExtraActionsthrough the auto-properties form pipeline. - openops AWS auth: validate roles in batches but aggregate failures across all roles into a single multi-line error message.
Blocking
addArrayItemsToSchemacurrently truncates existing array item schemas (existingItems.slice(0, previousArrayLength)), which can silently drop schemas if the schema andpreviousArrayLengthever drift.
Non-blocking
Merge recommendation
- Do not merge
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/react-ui/src/app/features/connections/lib/tests/aws-bulk-roles-utils.test.ts | Unit tests for account ID parsing and ARN helpers. |
| packages/react-ui/src/app/features/connections/lib/aws-bulk-roles-utils.ts | New parsing/building helpers for bulk AWS role generation. |
| packages/react-ui/src/app/features/connections/components/tests/create-edit-connection-dialog-content.test.tsx | Tests that bulk trigger shows only for AWS and summary behavior works. |
| packages/react-ui/src/app/features/connections/components/tests/aws-bulk-roles-panel.test.tsx | Panel-level behavior tests (counts, disable rules, append behavior, RHF regression coverage). |
| packages/react-ui/src/app/features/connections/components/custom-auth-connection-settings.tsx | Forwards arrayExtraActions down to the auto-properties form. |
| packages/react-ui/src/app/features/connections/components/create-edit-connection-dialog-content.tsx | Wires AWS-only bulk UI into roles array footer and adjusts validation banner for large role counts. |
| packages/react-ui/src/app/features/connections/components/aws-bulk-roles.tsx | AWS-specific footer action: trigger button, panel toggling, and post-add summary + scroll behavior. |
| packages/react-ui/src/app/features/connections/components/aws-bulk-roles-panel.tsx | Bulk panel UI and logic to append roles via setValue + schema growth. |
| packages/react-ui/src/app/features/builder/dynamic-form-validation/tests/dynamic-form-validation-context.test.tsx | Tests for new batched addArrayItemsToSchema behavior. |
| packages/react-ui/src/app/features/builder/dynamic-form-validation/dynamic-form-validation-context.tsx | Adds addArrayItemsToSchema to batch-grow tuple schemas for arrays. |
| packages/react-ui/src/app/features/builder/block-properties/tests/array-property.test.tsx | Tests new array footer slot rendering. |
| packages/react-ui/src/app/features/builder/block-properties/auto-properties-form.tsx | Threads arrayExtraActions to array properties. |
| packages/react-ui/src/app/features/builder/block-properties/array-property.tsx | Adds extraActions slot next to “Add Item” in array footer. |
| packages/react-ui/public/locales/en/translation.json | Adds new i18n keys for bulk-add UI and updated AWS validation banner text. |
| packages/openops/test/aws/auth.test.ts | Updates/extends tests for aggregated multi-role validation error formatting. |
| packages/openops/src/lib/aws/auth.ts | Aggregates all role assumption failures across batches into one formatted error message. |
| OPS-4753-bulk-aws-accounts-spec.md | Adds an MVP spec document describing the UX and implementation decisions. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Fixes OPS-4753.
Additional Notes
Newly added:
Add Itembutton to add multiple roles in bulkChanges in current behaviour:
Note
roles[]