Skip to content

8306408: Fix the format of several tables in building.md - #773

Open
zzambers wants to merge 1 commit into
openjdk:masterfrom
zzambers:tables-fix
Open

8306408: Fix the format of several tables in building.md#773
zzambers wants to merge 1 commit into
openjdk:masterfrom
zzambers:tables-fix

Conversation

@zzambers

@zzambers zzambers commented Mar 17, 2026

Copy link
Copy Markdown
Contributor

Backport fixing tables in doc/building.md, so they would display correctly in GitHub. Changes to doc/building.md were done manually, as tables in jdk8 doc differ from jdk11. So backport is done in spirit of original, actual change set is different.



Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • JDK-8306408 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8306408: Fix the format of several tables in building.md (Enhancement - P4 - Requested)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/773/head:pull/773
$ git checkout pull/773

Update a local copy of the PR:
$ git checkout pull/773
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/773/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 773

View PR using the GUI difftool:
$ git pr show -t 773

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/773.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper

bridgekeeper Bot commented Mar 17, 2026

Copy link
Copy Markdown

👋 Welcome back zzambers! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented Mar 17, 2026

Copy link
Copy Markdown

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk Bot changed the title Backport 659a4669208645420e151e78ab5fd3ac3808b310 8306408: Fix the format of several tables in building.md Mar 17, 2026
@openjdk

openjdk Bot commented Mar 17, 2026

Copy link
Copy Markdown

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk Bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Mar 17, 2026
@mlbridge

mlbridge Bot commented Mar 17, 2026

Copy link
Copy Markdown

Webrevs

@bridgekeeper

bridgekeeper Bot commented Apr 15, 2026

Copy link
Copy Markdown

@zzambers This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@zzambers

Copy link
Copy Markdown
Contributor Author

/touch

@openjdk

openjdk Bot commented Apr 15, 2026

Copy link
Copy Markdown

@zzambers The pull request is being re-evaluated and the inactivity timeout has been reset.

@openjdk openjdk Bot removed the rfr Pull request is ready for review label Apr 15, 2026
@zzambers

Copy link
Copy Markdown
Contributor Author

/template append

@openjdk

openjdk Bot commented May 11, 2026

Copy link
Copy Markdown

@zzambers The pull request template has been appended to the pull request body

@openjdk openjdk Bot added the rfr Pull request is ready for review label May 11, 2026

@gnu-andrew gnu-andrew left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

building.md changes look fine to me. I assume building.html was just re-generated from this?

@openjdk

openjdk Bot commented Jun 4, 2026

Copy link
Copy Markdown

⚠️ @zzambers This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@bridgekeeper

bridgekeeper Bot commented Jul 3, 2026

Copy link
Copy Markdown

@zzambers This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@gnu-andrew

Copy link
Copy Markdown
Member

@zzambers want to get this one approved?

@bridgekeeper

bridgekeeper Bot commented Jul 31, 2026

Copy link
Copy Markdown

@zzambers This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@zzambers

zzambers commented Aug 3, 2026

Copy link
Copy Markdown
Contributor Author

/touch

@openjdk

openjdk Bot commented Aug 3, 2026

Copy link
Copy Markdown

@zzambers The pull request is being re-evaluated and the inactivity timeout has been reset.

@zzambers

zzambers commented Aug 3, 2026

Copy link
Copy Markdown
Contributor Author

/approval request Fixes table formating in building.md, does changes to documentation only

@openjdk

openjdk Bot commented Aug 3, 2026

Copy link
Copy Markdown

@zzambers
8306408: The approval request has been created successfully.

@zzambers

zzambers commented Aug 3, 2026

Copy link
Copy Markdown
Contributor Author

@zzambers want to get this one approved?

Ah, missed this one :)

@openjdk openjdk Bot added the approval Requires approval; will be removed when approval is received label Aug 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants