8306408: Fix the format of several tables in building.md - #773
Conversation
|
👋 Welcome back zzambers! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
This backport pull request has now been updated with issue from the original commit. |
|
@zzambers This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
|
/touch |
|
@zzambers The pull request is being re-evaluated and the inactivity timeout has been reset. |
|
/template append |
|
@zzambers The pull request template has been appended to the pull request body |
gnu-andrew
left a comment
There was a problem hiding this comment.
building.md changes look fine to me. I assume building.html was just re-generated from this?
|
|
|
@zzambers This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
|
@zzambers want to get this one approved? |
|
@zzambers This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
|
/touch |
|
@zzambers The pull request is being re-evaluated and the inactivity timeout has been reset. |
|
/approval request Fixes table formating in building.md, does changes to documentation only |
Ah, missed this one :) |
Backport fixing tables in
doc/building.md, so they would display correctly in GitHub. Changes todoc/building.mdwere done manually, as tables in jdk8 doc differ from jdk11. So backport is done in spirit of original, actual change set is different.Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/773/head:pull/773$ git checkout pull/773Update a local copy of the PR:
$ git checkout pull/773$ git pull https://git.openjdk.org/jdk8u-dev.git pull/773/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 773View PR using the GUI difftool:
$ git pr show -t 773Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/773.diff
Using Webrev
Link to Webrev Comment