Skip to content

ci: bump Go, golangci-lint, codespell, and runners - #70

Merged
thaJeztah merged 3 commits into
opencontainers:mainfrom
kolyshkin:ci-bumps-II
Aug 12, 2026
Merged

ci: bump Go, golangci-lint, codespell, and runners#70
thaJeztah merged 3 commits into
opencontainers:mainfrom
kolyshkin:ci-bumps-II

Conversation

@kolyshkin

@kolyshkin kolyshkin commented Aug 3, 2026

Copy link
Copy Markdown
Contributor
  • Test matrix: stable, oldstable and a version from go.mod.
  • Validate jobs: simplify to just use stable.
  • golangci-lint: v2.4 -> v2.12.
  • codespell: 2.4.1 -> 2.4.3.
  • Runners: ubuntu-24.04 -> ubuntu-26.04.

The actions themselves are already kept current by dependabot.

@kolyshkin
kolyshkin requested a review from a team as a code owner August 3, 2026 22:53
@kolyshkin kolyshkin added this to the 0.0.9 milestone Aug 3, 2026
@kolyshkin

Copy link
Copy Markdown
Contributor Author

CI bumps; easy to review; PTAL @opencontainers/cgroups-maintainers

Comment thread .github/workflows/test.yml Outdated
fail-fast: false
matrix:
go-version: [1.24.x, 1.25.x]
go-version: [1.24.x, 1.26.x]

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just test oldstable and stable

Comment thread .github/workflows/test.yml Outdated
@kolyshkin

Copy link
Copy Markdown
Contributor Author

Can we just test oldstable and stable

@AkihiroSuda we also have to specify the version from go.mod, and in case this version is accidentally the same as "oldstable" or "stable", we have the test running twice on the same Go version.

If we use numbers, we can clearly see if there's redundancy here.

What do you think?

@kolyshkin

kolyshkin commented Aug 5, 2026

Copy link
Copy Markdown
Contributor Author

Can we just test oldstable and stable

@AkihiroSuda we also have to specify the version from go.mod, and in case this version is accidentally the same as "oldstable" or "stable", we have the test running twice on the same Go version.

If we use numbers, we can clearly see if there's redundancy here.

What do you think?

More arguments towards keeping the versions explicit (as opposed to using stable/oldstable and derive Go version from go.mod) are in #15.

@thaJeztah

Copy link
Copy Markdown
Member

Yeah, pros and cons to each; for some repositories, I'm using go.mod itself as "minimum", and "oldstable", "stable" for the upper-bound, but that's usually for repositories that don't get frequent updates. If we want to use fixed versions, we could consider adding tip to get an early warning for things that may break in the near future.

Here's what I did on some of those repositories;

Even if we decide not to use oldstable, stable, using the custom names could still be useful to get stable names in the CI tasks (although we handled it here with the "all-done" I think?)

kolyshkin and others added 2 commits August 10, 2026 12:30
 * golangci-lint: v2.4 -> v2.12.
 * codespell: 2.4.1 -> 2.4.3.
 * Runners: ubuntu-24.04 -> ubuntu-26.04.

The actions themselves are already kept current by dependabot.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Use stable (currently 1.26) for validate jobs.

Use oldstable and stable (currently 1.25 and 1.26) for test jobs,
as well as minimal Go version as specified in go.mod.

This way we won't have to update Go versions in CI every 6 months.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
@kolyshkin

Copy link
Copy Markdown
Contributor Author

OK I've reverted to using oldstable, stable and go-version-file: go.mod. This means we won't have to update versions used for CI, but also that CI is slightly more prone to breakage (but I'm fine with it).

PTAL @thaJeztah

Instead of using a standalone go fix (and a separate job), add
modernize and govet (which should be same-as/similar-to go fix)
linters to golangci-lint config.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>

@thaJeztah thaJeztah left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
thaJeztah merged commit 8bbeb6b into opencontainers:main Aug 12, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants