ci: bump Go, golangci-lint, codespell, and runners - #70
Conversation
|
CI bumps; easy to review; PTAL @opencontainers/cgroups-maintainers |
| fail-fast: false | ||
| matrix: | ||
| go-version: [1.24.x, 1.25.x] | ||
| go-version: [1.24.x, 1.26.x] |
There was a problem hiding this comment.
Can we just test oldstable and stable
@AkihiroSuda we also have to specify the version from go.mod, and in case this version is accidentally the same as "oldstable" or "stable", we have the test running twice on the same Go version. If we use numbers, we can clearly see if there's redundancy here. What do you think? |
More arguments towards keeping the versions explicit (as opposed to using |
|
Yeah, pros and cons to each; for some repositories, I'm using Here's what I did on some of those repositories; Even if we decide not to use |
* golangci-lint: v2.4 -> v2.12. * codespell: 2.4.1 -> 2.4.3. * Runners: ubuntu-24.04 -> ubuntu-26.04. The actions themselves are already kept current by dependabot. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Use stable (currently 1.26) for validate jobs. Use oldstable and stable (currently 1.25 and 1.26) for test jobs, as well as minimal Go version as specified in go.mod. This way we won't have to update Go versions in CI every 6 months. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
|
OK I've reverted to using PTAL @thaJeztah |
Instead of using a standalone go fix (and a separate job), add modernize and govet (which should be same-as/similar-to go fix) linters to golangci-lint config. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
stable,oldstableand a version fromgo.mod.stable.The actions themselves are already kept current by dependabot.