Skip to content

fix(ci): stamp version into daily docker images - #3291

Merged
v-scharf merged 2 commits into
mainfrom
fix/docker-daily-version-stamp
Aug 12, 2026
Merged

fix(ci): stamp version into daily docker images#3291
v-scharf merged 2 commits into
mainfrom
fix/docker-daily-version-stamp

Conversation

@v-scharf

@v-scharf v-scharf commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Since d0a0922e89 the docker build context moved from ".." to ".", which activated the repo-root .dockerignore that excludes .git.
Without .git the Makefile's git rev-parse --short HEAD fails ("fatal: not a git repository") and version.String stays empty, so every daily image reports the fallback LatestTag and looks unchanged.

Pass STRING/VERSION/EDITION as build args into the docker build instead of relying on git inside the build context.

@v-scharf v-scharf added the Type:DevOps Related to CI/CD label Aug 12, 2026
@v-scharf
v-scharf requested review from JammingBen and flimmy August 12, 2026 08:40
@codacy-production

codacy-production Bot commented Aug 12, 2026

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Coverage ∅ diff coverage · +0.00% coverage variation

Metric Results
Coverage variation +0.00% coverage variation (-1.00%)
Diff coverage diff coverage

View coverage diff in Codacy

Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (716922f) 84012 19270 22.94%
Head commit (63f9697) 84012 (+0) 19270 (+0) 22.94% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#3291) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

Comment thread .woodpecker.star Outdated
Comment thread opencloud/docker/Dockerfile.multiarch Outdated
@v-scharf
v-scharf requested a review from JammingBen August 12, 2026 09:32
@v-scharf
v-scharf merged commit b41d0c1 into main Aug 12, 2026
62 of 63 checks passed
@v-scharf
v-scharf deleted the fix/docker-daily-version-stamp branch August 12, 2026 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type:DevOps Related to CI/CD

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants