Add toString to OtlpJsonLogging exporters - #8725
Draft
thswlsqls wants to merge 1 commit into
Draft
Conversation
Contributor
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8725 +/- ##
=========================================
Coverage 91.26% 91.26%
- Complexity 10461 10464 +3
=========================================
Files 1006 1006
Lines 28244 28247 +3
Branches 3564 3564
=========================================
+ Hits 25778 25781 +3
Misses 1674 1674
Partials 792 792 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8724
Description
OtlpJsonLoggingMetricExporter,OtlpJsonLoggingSpanExporterandOtlpJsonLoggingLogRecordExporterhad notoString(), so they printed an identity hash such asOtlpJsonLoggingMetricExporter@6d06d69c.PeriodicMetricReader.toString()embeds the exporter as"exporter=" + exporter.AggregationTemporalitypassed tocreate(AggregationTemporality).:exporters:logging:LoggingMetricExporter{aggregationTemporality=...},LoggingSpanExporter{},SystemOutLogRecordExporter{}.OtlpStdout*Exporterdoes not work: it is not exposed, andcreate(AggregationTemporality)never forwards the temporality, so the delegate still reports the builder defaultalwaysCumulative().Testing done
stringRepresentation()toOtlpJsonLoggingMetricExporterTest(cumulative and delta),OtlpJsonLoggingSpanExporterTestandOtlpJsonLoggingLogRecordExporterTest. All three fail onmainand pass with this change../gradlew :exporters:logging-otlp:check— 80 tests passed, 0 failures.docs/apidiffs/current_vs_latest/opentelemetry-exporter-logging-otlp.txt.