fix(plugin-map): type-check its tests (#4040 tranche 1) - #4270
Merged
Conversation
…4040) `packages/plugin-map` gains a `tsconfig.test.json` on the objectui#3032 template, chained from its `type-check` script, so its four test files are compiled by something for the first time. Its one declared code-tier error was config-tier under a fuller template: TS2882 on `ObjectMap.tsx`'s side-effect import of maplibre's CSS, raised only because `src/global.d.ts` — which declares `*.css` — was not a program input. An ambient declaration is a program input only when a pattern names it; being reachable by import is not enough, since nothing imports it. No source changed. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017Qqyix2QcnpUC9XeYVDzx3
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
✅ Console Performance Budget
📦 Bundle Size Report
Size Limits
|
yinlianghui
marked this pull request as ready for review
August 11, 2026 11:22
This was referenced Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #4040 — tranche 1, package 1 of 5. One package per PR, per the 裁决 on objectstack-ai/objectstack#4118 (PM, 2026-08-03):
Measured before / after
TEST_DEBT4cb0562b5)Before, with the objectui#3032 template applied as-is:
The one error was config-tier, not code-tier — no source changed
That
TS2882is not a defect inObjectMap.tsx; the package build compiles thatsame file cleanly. It is raised because
src/global.d.ts, which declares*.css,was not a program input of the new project. An ambient declaration file is a program
input only when a pattern NAMES it — being reachable by import is not enough, because
nothing imports it. The build program gets it for free from
"include": ["src"]; thetest project's include listed only test globs.
So the fix is
"src/**/*.d.ts"ininclude, and this package needed zero sourceor test changes. That is the same reclassification
sdui-parser's 50TS2304s got inobjectui#3032 (env globals, config-tier) — worth flagging because the general shape
generalizes: any package whose build inherits ambient declarations from
"include": ["src"]will re-raise them here unless the test project names them too.Discrimination proof — the new project can fail
A
tsconfig.test.jsonthat exists but compiles nothing is the objectui#3009 shape andthe third failure mode the 4118 thread names. Since no guard test's assertions changed
here, the thing that needs its discrimination proven is the new project itself: does it
really read these test files? Appending a provably-false line to
src/ObjectMap.test.tsxand re-running:
Reverted immediately; the probe is not in the diff.
Verification
TEST_DEBTshrinks by exactly this package's line (240 to 239 outstanding); no otherentry is touched, so the registry is the only file this tranche's PRs share.
The changeset carries empty frontmatter on purpose: config-only, releases nothing.
Generated by Claude Code