fix(store): fence concurrent record reads - #7
Open
nstranquist wants to merge 5 commits into
Open
Conversation
Owner
Author
|
Windows stress attempt 3 reproduced the original failure with typed evidence: STORE_FAILED while Current/Status opened a lease record during another lane heartbeat atomic replacement. The operational reads and RecordCommit now use the same registry fence as lease replacement (11e1915), with deterministic fence tests plus 100 local concurrent capture iterations. Hosted Windows verification is running on the fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
Hosted attempt 3 reproduced STORE_FAILED while Current/Status opened a lease record during another lane heartbeat replacement:
https://github.com/nstranquist/wip-commit/actions/runs/32035869370/attempts/3
Unix permits the rename window. Windows can reject the open with a sharing violation. The registry fence now covers both sides of that operation.
Verification
Refs #6.