Skip to content

esm: only register text format when enabled - #64992

Open
efekrskl wants to merge 1 commit into
nodejs:mainfrom
efekrskl:esm/fix-userland-text-loaders
Open

esm: only register text format when enabled#64992
efekrskl wants to merge 1 commit into
nodejs:mainfrom
efekrskl:esm/fix-userland-text-loaders

Conversation

@efekrskl

@efekrskl efekrskl commented Aug 3, 2026

Copy link
Copy Markdown
Member

#62300 broke userland text loaders (more details 1, 2)

This PR aims to fix this by only conditionally adding text import if the feature flag is enabled (similarly to initializeExtensionFormatMap) and adds a regression test

Signed-off-by: Efe Karasakal <hi@efe.dev>
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/loaders

@nodejs-github-bot nodejs-github-bot added esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. process Issues and PRs related to the process subsystem. labels Aug 3, 2026
@codecov

codecov Bot commented Aug 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.28%. Comparing base (f00fb75) to head (c1640e8).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #64992   +/-   ##
=======================================
  Coverage   90.27%   90.28%           
=======================================
  Files         762      762           
  Lines      247534   247540    +6     
  Branches    46694    46685    -9     
=======================================
+ Hits       223457   223487   +30     
+ Misses      15529    15492   -37     
- Partials     8548     8561   +13     
Files with missing lines Coverage Δ
lib/internal/modules/esm/assert.js 100.00% <100.00%> (ø)
lib/internal/process/pre_execution.js 97.84% <100.00%> (+0.12%) ⬆️

... and 34 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. process Issues and PRs related to the process subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants