Skip to content

tools: add ./tools/nix/pkcs11.nix to nix-changes.yml - #64967

Open
panva wants to merge 1 commit into
nodejs:mainfrom
panva:tools-followup
Open

tools: add ./tools/nix/pkcs11.nix to nix-changes.yml#64967
panva wants to merge 1 commit into
nodejs:mainfrom
panva:tools-followup

Conversation

@panva

@panva panva commented Aug 2, 2026

Copy link
Copy Markdown
Member

@panva
tools: add ./tools/nix/pkcs11.nix to nix-changes.yml
e3e806c 
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
@panva
panva requested a review from aduh95 August 2, 2026 20:22
@nodejs-github-bot

nodejs-github-bot commented Aug 2, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Aug 2, 2026
@panva panva added tools Issues and PRs related to the tools directory. and removed meta Issues and PRs related to the general management of the project. labels Aug 2, 2026
@aduh95 aduh95 added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Aug 2, 2026
@github-actions

github-actions Bot commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @aduh95. Please 👍 to approve.

@aduh95 aduh95 mentioned this pull request Aug 3, 2026
Open
@aduh95 aduh95 added dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. labels Aug 3, 2026
@panva

panva commented Aug 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

@bnb 👍 alone won't cut it, this also needs a second approval to be able to fast-track 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aduh95 aduh95 aduh95 approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. fast-track PRs that do not need to wait for 48 hours to land. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@panva @nodejs-github-bot @aduh95