adds beta docs to learn by bmuenzenmeyer · Pull Request #114 · nodejs/learn

bmuenzenmeyer · 2026-07-30T22:22:53Z

Need to see if we need to update ui-components or any other aspect of what made the nav accent.
cross-ref nodejs/nodejs.org#8998

vercel · 2026-07-30T22:22:59Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
nodejs-learn	Ready	Preview	Aug 3, 2026 1:31pm

github-actions · 2026-07-30T22:23:03Z

👋 Codeowner Review Request

The following codeowners have been identified for the changed files:

Team reviewers: @nodejs/nodejs-website

Please review the changes when you have a chance. Thank you! 🙏

Copilot

🟡 Not ready to approve

The new NavBar entry uses a label i18n key that is not defined/used elsewhere in this repo and is inconsistent with existing text fields, likely causing an incorrect or missing link label.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.

Pull request overview

This PR adds a new top-level navigation link to the Node.js Beta documentation site in site.json, intended to surface “Beta Docs” prominently in the Learn site NavBar.

Changes:

Add a new NavBar item linking to https://beta.docs.nodejs.org/
Mark the new link as opening in a new tab and visually accented

File summaries

File	Description
site.json	Adds a new navigation entry for the Beta docs site in the main NavBar list.

Review details

Files reviewed: 1/1 changed files
Comments generated: 1
Review effort level: Lite

We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.

Copilot

🟡 Not ready to approve

The new nav item uses label instead of text, which is likely to render the link with no visible text given how navItems are passed through.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.

Review details

Comments suppressed due to low confidence (1)

site.json:21

This new nav entry uses label, but the rest of site.json navigation items use text, and components/Navigation/index.jsx passes navItems={navigation} directly into @node-core/ui-components NavBar (no label->text mapping). As a result, this item will likely render with an empty label. Use text (or add mapping code, but that would be a separate change).

      "label": "components.containers.navBar.links.betaDocs",

Files reviewed: 2/3 changed files
Comments generated: 0 new
Review effort level: Lite

We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.

Copilot

🟡 Not ready to approve

The new nav entry uses label instead of text, which likely prevents the Beta Docs link text from rendering with the current NavBar integration.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.

Review details

Comments suppressed due to low confidence (1)

site.json:23

components/Navigation passes navigation directly into @node-core/ui-components/Containers/NavBar, which expects each item to provide a text field (as the other entries in site.json do). Using label here will likely result in the Beta Docs item rendering without any visible text (and the i18n key isn’t resolved in this repo).

      "link": "https://beta.docs.nodejs.org/",
      "label": "components.containers.navBar.links.betaDocs",
      "target": "_blank",
      "accent": true

Files reviewed: 2/3 changed files
Comments generated: 0 new
Review effort level: Lite

We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.

bmuenzenmeyer · 2026-07-31T12:00:48Z

this repo specifically i have all kinds of janky lockfile problems with.

Copilot

🟢 Ready to approve

The changes are small, consistent with existing navigation patterns, and the dependency + lockfile updates align with the new nav behavior.

This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.

Review details

Files reviewed: 2/3 changed files
Comments generated: 0 new
Review effort level: Lite

We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.

Copilot

🟢 Ready to approve

The change is small, aligns with the referenced upstream implementation, and the dependency bump matches the new nav item shape.

This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.

Review details

Files reviewed: 2/3 changed files
Comments generated: 0 new
Review effort level: Lite

We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.

bmuenzenmeyer · 2026-08-01T19:56:03Z

@avivkeller these lint failures may be worrisome. the thinks are working in production so there might be some incompatibility in the rule

avivkeller · 2026-08-01T20:09:29Z

the thinks are working in production so there might be some incompatibility in the rule

Look at https://github.com/nodejs/nodejs.org/blob/main/apps/site/.remarkrc.json. I probably need to allow for mapping /learn as the root

avivkeller · 2026-08-01T20:10:09Z

That being said, they are just warnings (since they can be slightly inaccurate, as you can see) and can be ignored, the error is from prettier

bmuenzenmeyer · 2026-08-02T21:41:35Z

I see that now with prettier - oddly still, my prettier output is clean.

On branch learn-beta-docs
Your branch is up to date with 'origin/learn-beta-docs'.

nothing to commit, working tree clean
➜  learn git:(learn-beta-docs) npm run format:check

> format:check
> prettier --check .

Checking formatting...
All matched files use Prettier code style!

cursor · 2026-08-02T21:41:41Z

PR Summary

Low Risk
Navigation and dependency version bump only; no application logic or security-sensitive changes in this repo.

Overview
Adds a Beta Docs entry to the site navigation in site.json, linking to https://beta.docs.nodejs.org/ in a new tab with accent: true so it stands out like the main nodejs.org nav.

Bumps @node-core/ui-components from ^1.7.3 to ^1.7.4 in package.json (with a large package-lock.json refresh from that bump and related transitive updates).

^{Reviewed by Cursor Bugbot for commit f2724ee. Bugbot is set up for automated code reviews on this repo. Configure here.}

ovflowd · 2026-08-03T09:15:10Z

      "link": "/blog",
      "text": "Blog"
    },
+    {


The order is wrong compared to nodejs.org, should be after the old docs entry

good catch addressed via f2724ee

Copilot

🟢 Ready to approve

The changes are small, consistent with existing navigation configuration, and the dependency bump aligns with the new nav item’s usage.

This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.

Review details

Files reviewed: 2/3 changed files
Comments generated: 0 new
Review effort level: Lite

We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.

adds beta docs to learn

d031648

Copilot AI review requested due to automatic review settings July 30, 2026 22:22

Copilot started reviewing on behalf of bmuenzenmeyer July 30, 2026 22:23 View session

Copilot AI reviewed Jul 30, 2026

View reviewed changes

Comment thread site.json

bump ui-components

14786ea

Copilot AI review requested due to automatic review settings July 30, 2026 22:27

vercel Bot deployed to Preview July 30, 2026 22:28 View deployment

Copilot started reviewing on behalf of bmuenzenmeyer July 30, 2026 22:28 View session

what you doing node_modules

d0afffa

Copilot AI reviewed Jul 30, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings July 30, 2026 22:30

vercel Bot deployed to Preview July 30, 2026 22:30 View deployment

Copilot started reviewing on behalf of bmuenzenmeyer July 30, 2026 22:30 View session

Copilot AI reviewed Jul 30, 2026

View reviewed changes

avivkeller reviewed Jul 30, 2026

View reviewed changes

Comment thread site.json Outdated

Copilot AI review requested due to automatic review settings July 31, 2026 11:59

vercel Bot deployed to Preview July 31, 2026 11:59 View deployment

Copilot started reviewing on behalf of bmuenzenmeyer July 31, 2026 12:00 View session

Copilot AI previously approved these changes Jul 31, 2026

View reviewed changes

bmuenzenmeyer added 2 commits July 31, 2026 14:13

resolve lockfile problem

4632650

use direct text

63871b3

Copilot AI review requested due to automatic review settings July 31, 2026 19:15

bmuenzenmeyer force-pushed the learn-beta-docs branch from 2ff2bc2 to 63871b3 Compare July 31, 2026 19:15

vercel Bot deployed to Preview July 31, 2026 19:15 View deployment

Copilot started reviewing on behalf of bmuenzenmeyer July 31, 2026 19:16 View session

Copilot AI dismissed their stale review, a newer Copilot review was requested July 31, 2026 19:20

Copilot AI previously approved these changes Jul 31, 2026

View reviewed changes

bmuenzenmeyer marked this pull request as ready for review August 2, 2026 21:41

bmuenzenmeyer requested a review from a team as a code owner August 2, 2026 21:41

AugustinMauroy approved these changes Aug 3, 2026

View reviewed changes

ovflowd reviewed Aug 3, 2026

View reviewed changes

chore: reorder beta docs after current

f2724ee

Copilot AI review requested due to automatic review settings August 3, 2026 13:31

vercel Bot deployed to Preview August 3, 2026 13:31 View deployment

Copilot started reviewing on behalf of bmuenzenmeyer August 3, 2026 13:31 View session

Copilot AI dismissed their stale review, a newer Copilot review was requested August 3, 2026 13:34

Copilot AI approved these changes Aug 3, 2026

View reviewed changes

Uh oh!

Conversation

bmuenzenmeyer commented Jul 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vercel Bot commented Jul 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 30, 2026

👋 Codeowner Review Request

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Not ready to approve

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Not ready to approve

Comments suppressed due to low confidence (1)

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Not ready to approve

Comments suppressed due to low confidence (1)

Uh oh!

Uh oh!

bmuenzenmeyer commented Jul 31, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟢 Ready to approve

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟢 Ready to approve

Uh oh!

bmuenzenmeyer commented Aug 1, 2026

Uh oh!

avivkeller commented Aug 1, 2026

Uh oh!

avivkeller commented Aug 1, 2026

Uh oh!

bmuenzenmeyer commented Aug 2, 2026

Uh oh!

cursor Bot commented Aug 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

Uh oh!

ovflowd Aug 3, 2026

Choose a reason for hiding this comment

Uh oh!

bmuenzenmeyer Aug 3, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟢 Ready to approve

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

bmuenzenmeyer commented Jul 30, 2026 •

edited

Loading

vercel Bot commented Jul 30, 2026 •

edited

Loading

cursor Bot commented Aug 2, 2026 •

edited

Loading