chore: disable install scripts via allowScripts and fix audit vulnerabilities - #1009
chore: disable install scripts via allowScripts and fix audit vulnerabilities#1009btea wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR SummaryLow Risk Overview Updates Reviewed by Cursor Bugbot for commit 7cb1f9c. Bugbot is set up for automated code reviews on this repo. Configure here. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1009 +/- ##
=======================================
Coverage 89.63% 89.63%
=======================================
Files 200 200
Lines 18501 18501
Branches 1729 1729
=======================================
Hits 16584 16584
Misses 1910 1910
Partials 7 7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Adds npm install-script controls and refreshes the npm lockfile to address audit findings, aligning this repo with the newer npm “approve/deny dependency scripts” workflow referenced in #997.
Changes:
- Add a root
allowScriptsconfiguration to deny install scripts forfseventsandunrs-resolver. - Update
package-lock.jsonto incorporate vulnerability-related dependency bumps (e.g.,brace-expansion,undici).
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package.json | Adds allowScripts entries to disable specific dependency install scripts. |
| package-lock.json | Updates resolved dependency versions/integrities to pick up security/audit-related fixes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
MattIPv4
left a comment
There was a problem hiding this comment.
The changes here seem fine, but as a more general note, I like to leave any changes to dependencies to Dependabot (or rarely, collaborators) -- having external contributors touching lock files introduces a lot of risk for something being snuck in maliciously.
Again, the diff here is fine, the lockfile change is legit, just a general callout.
ovflowd
left a comment
There was a problem hiding this comment.
I don't really get why these specific packages to be unallowed.
|
@ovflowd It's all of our packges that use install scripts, since we don't need them |
Description
refer to #997 (comment)
Validation
Related Issues
Check List
node --run testand all tests passed.node --run format:check&node --run lint.