fix(auto-upload): skip check

[alperozturk96]

Issue

Worker might mark entity as handled but this is not enough worker may get killed and never reached to the actual upload thus oc upload records should be checked as well.

Fixes

#15573

[github-actions]

APK file: https://github.com/nextcloud/android/actions/runs/30632262721/artifacts/8794164956
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
(please click on link to get QR code displayed)

[github-actions]

master-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/17401-IT-master-13-46

[DricomDragon]

I installed the QA app, logged in, gave permission to manage all files, (disabled auto-upload on stock APK), configured the auto upload of video and photograph in camera (after having renamed the previous folder to Camera1 to prevent mass upload), Wi-Fi is enabled, I plugged my phone, took a photograph and video : no effect.

Unplug from charger, plug to my computer, capture logs, go to uploads, pause / play, go to manage auto uploads : I can see my picture and video in the auto-upload configurator, but nothing automatically uploaded yet. Maybe unrelated to your patch, though.

Here are the logs :
qa-logs-redacted.txt

I will use this QA version from now on, I will notice you about uploads or skips when noticed.

Thanks for your amazing work, have a good day !

[alperozturk96]

/backport to stable-34.1.x

[github-actions]

Codacy

SpotBugs

Category	Base	New
Bad practice	32	32
Correctness	64	64
Dodgy code	215	215
Experimental	1	1
Malicious code vulnerability	2	2
Multithreaded correctness	25	25
Performance	40	40
Security	19	19
Total	398	398

[github-actions]

APK file: https://github.com/nextcloud/android/actions/runs/31084696925/artifacts/8961049995
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
(please click on link to get QR code displayed)

[github-actions]

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

[robdupas-svg]

Setup:

• Uninstalled F-Droid stable, installed QA build fresh
• No pre-existing Camera rule (no photos yet taken); a default, disabled ScreenRecorder rule was auto-created from recordings made the previous day
• Created a manual Camera rule pointing at DCIM/Camera

Test sequence and results:

1. Un-installed F-Droid app
2. Installed the QA version
   • Once opened, I was prompted to
   • Allow notifications
   • Allow access to all files
3. Started to create the Camera rule
   • recommendation to turn on background autostart (did this)
   • No default Camera rule (I had taken no photos yet)
   • Created it
   • Took longer than usual to discover the folders on my server
   • A default ScreenRecorder rule was already setup
   • I have taken some recordings yesterday
   • I left it disabled
4. Closed Nextcloud
5. Took a photo
   • Waited 60 seconds and it still did not automatically upload to the server
6. Opened Nextcloud app
   • Nothing automatically uploaded
   • 2 Camera rules now exist.
   • The one I created shows 5 photos (4 of which I deleted yesterday)
   • The Nextcloud generated Camera rule
7. Deleted the manually created rule
8. Configured and enabled the Nextcloud Camera rule
   • The photo uploaded automatically after I did this
9. Closed Nextcloud
10. Took another photo
11. Waited another minute
12. Nothing uploaded
13. Checked the app state
    • Apps\Manage apps\Nextcloud
    • Seems to be running as “Force stop” is not greyed out
14. Opened Nextcloud
    • Both photos I took appear as icons in the rule
    • Toggling upload had no effect
15. Created a new Camera rule
    • Photo uploaded automatically
16. Closed Nextcloud
17. Took another photo with both rules active
18. Waited another minute
19. No automatic upload so I opened Nextcloud
    • The custom rule still shows several photos I deleted yesterday + newly created photos
20. Still no automatic upload so I deleted the custom rule
21. No upload
22. Created a custom new rule again
23. No upload … nothing will upload again

Conclusion:
It appears the app is running in the background (13) above. The last time I tried the test, the Nextcloud camera rule was already created when I first open Auto upload. I can’t remember if I had photos on the phone already. However, it does appear the act of creating a custom folder (either before or after the Nextcloud rule) triggers the upload. This appears to only work once though as my uploads are now frozen.