code_review: default review_context_repo from the patch's own repo - #6488
Merged
suhaibmujahid merged 2 commits intoAug 4, 2026
Conversation
Contributor
Author
|
@suhaibmujahid implemented it as you said, with a set of defaults. |
Previously review_context_repo had to be passed explicitly to every review. Add Patch.github_repo()/github_repo_branch() hooks (default None/"main") so each platform can answer this from what it already knows. PhabricatorPatch resolves it by mapping the revision's repository callsign to its GitHub mirror and branch. The agent only consults this when the caller didn't pass review_context_repo explicitly, so existing callers are unaffected.
padenot
force-pushed
the
review-context-repo-default
branch
from
August 3, 2026 17:04
a04b2f8 to
755fcd9
Compare
suhaibmujahid
previously approved these changes
Aug 3, 2026
…at it's all or nothing
suhaibmujahid
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously review_context_repo had to be passed explicitly to every review. Add Patch.github_repo()/github_repo_branch() hooks (default None/"main") so each platform can answer this from what it already knows. PhabricatorPatch resolves it by mapping the revision's repository callsign to its GitHub mirror and branch. The agent only consults this when the caller didn't pass review_context_repo explicitly, so existing callers are unaffected.
When we're ready to make this work on github, it will be quite natural and quick to do.