fix: apply generate script LLM overrides - #936
Draft
ump45nose wants to merge 1 commit into
Draft
Conversation
ump45nose
force-pushed
the
codex/fix-generate-script-overrides
branch
from
August 11, 2026 07:17
e882f85 to
dac68ee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an ineffective
GenerateScript.prepare_llm()override: the method configured a copied config but passed the unmodified source config toLLM.from_config.Validation
python3 -m py_compile projects/singularity_cinema/generate_script/agent.pytemperature=0.6andtop_k=50, while the source config remains unchanged.Scope
One-line source fix; no dependency or behavior changes outside the singularity-cinema script-generation LLM setup.