Fix pick channels crash when _orig_units is None (#11314) - #14006
Merged
larsoner merged 5 commits intoAug 18, 2026
Conversation
CedricConday
requested review from
agramfort,
drammock,
larsoner and
mscheltienne
as code owners
June 30, 2026 03:49
larsoner
reviewed
Jun 30, 2026
Comment on lines
+703
to
+705
| import numpy as np | ||
|
|
||
| import mne |
Member
There was a problem hiding this comment.
No need to nest these they're required by MNE
CedricConday
force-pushed
the
fix/pick-channels-orig-units-none
branch
from
July 3, 2026 11:43
c39e6c3 to
1e8c790
Compare
drammock
previously requested changes
Jul 10, 2026
Comment on lines
+704
to
+705
| info = mne.create_info(["Fp1", "Fp2", "F3", "F4"], 100.0, "eeg") | ||
| raw = mne.io.RawArray(np.zeros((4, 100)), info) |
Member
There was a problem hiding this comment.
create_info and RawArray are already imported directly at top of file
Suggested change
| info = mne.create_info(["Fp1", "Fp2", "F3", "F4"], 100.0, "eeg") | |
| raw = mne.io.RawArray(np.zeros((4, 100)), info) | |
| info = create_info(["Fp1", "Fp2", "F3", "F4"], 100.0, "eeg") | |
| raw = RawArray(np.zeros((4, 100)), info) |
| from numpy.testing import assert_allclose, assert_array_equal, assert_equal | ||
| from scipy.io import savemat | ||
|
|
||
| import mne |
Member
There was a problem hiding this comment.
unnecessary; the two API items you use (RawArray and create_info) are already being imported directly, just a few lines down.
CedricConday
added a commit
to CedricConday/mne-python
that referenced
this pull request
Jul 10, 2026
Address @drammock review on mne-tools#14006: create_info and RawArray are already imported directly at the top of the test module, so call them directly and remove the now-unused `import mne`. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LyuFNWN45FNffpGwsC4Su7
Contributor
Author
CedricConday
force-pushed
the
fix/pick-channels-orig-units-none
branch
from
July 12, 2026 10:29
23ae216 to
faddba6
Compare
CedricConday
added a commit
to CedricConday/mne-python
that referenced
this pull request
Jul 12, 2026
Address @drammock review on mne-tools#14006: create_info and RawArray are already imported directly at the top of the test module, so call them directly and remove the now-unused `import mne`.
Picking/reordering channels built {k: v for ... in self._orig_units.items()}
unconditionally, raising AttributeError when _orig_units is None (as produced
by some readers / RawArray flows). Guard for a falsy _orig_units. Adds a test.
Address @drammock review on mne-tools#14006: create_info and RawArray are already imported directly at the top of the test module, so call them directly and remove the now-unused `import mne`.
CedricConday
force-pushed
the
fix/pick-channels-orig-units-none
branch
from
July 12, 2026 18:15
faddba6 to
2764419
Compare
CedricConday
added a commit
to CedricConday/mne-python
that referenced
this pull request
Jul 12, 2026
Address @drammock review on mne-tools#14006: create_info and RawArray are already imported directly at the top of the test module, so call them directly and remove the now-unused `import mne`.
CedricConday
force-pushed
the
fix/pick-channels-orig-units-none
branch
from
August 18, 2026 10:20
2764419 to
c3a789b
Compare
Contributor
Author
|
@drammock — the nested I can't re-request review via the API as a non-collaborator, so flagging it here instead — this has been sitting in changes requested since 10 July with nothing actually outstanding. Sorry for not surfacing it sooner. AI-assisted, human-reviewed. |
Member
|
Okay I think the review comments have been addressed so this can go in, thanks @CedricConday ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11314
What was wrong
When picking/reordering channels on a
Raw, the code rebuilds_orig_units:If
self._orig_unitsisNone(which happens with some readers andRawArrayflows), this raisesAttributeError: 'NoneType' object has no attribute 'items'. The pick itself otherwise succeeds.Fix
Only rebuild
_orig_unitswhen it is truthy; leaveNone/empty as-is.Test
Adds
test_pick_channels_orig_units_none: picking with_orig_units = Noneno longer raises. Verified it raisesAttributeErroronmainand passes with this change.AI-assisted, human-reviewed — I'm an AI engineer; I find, fix, and test with AI (Claude Code), then review and verify before opening.