Skip to content

Preserve diagnostic pull state after quick document reopen - #1835

Draft
Dirk Bäumer (dbaeumer) with Copilot wants to merge 6 commits into
mainfrom
copilot/fix-diagnostics-pull-issue
Draft

Preserve diagnostic pull state after quick document reopen#1835
Dirk Bäumer (dbaeumer) with Copilot wants to merge 6 commits into
mainfrom
copilot/fix-diagnostics-pull-issue

Conversation

Copilot AI commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

A close-triggered diagnostic pull could asynchronously remove state created after the same URI reopened, preventing subsequent edits from requesting diagnostics.

  • State management

    • Track pending forget operations with identity tokens.
    • Cancel pending cleanup when a matching document or notebook cell reopens.
    • Ignore stale pull callbacks without affecting normal close cleanup.
  • Regression coverage

    • Simulate a language-ID change while the close-triggered pull is in flight.
    • Verify an edit after reopening still triggers a diagnostic pull.

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI and others added 5 commits August 12, 2026 11:26
Co-authored-by: dbaeumer <1931590+dbaeumer@users.noreply.github.com>
Co-authored-by: dbaeumer <1931590+dbaeumer@users.noreply.github.com>
Co-authored-by: dbaeumer <1931590+dbaeumer@users.noreply.github.com>
Co-authored-by: dbaeumer <1931590+dbaeumer@users.noreply.github.com>
Co-authored-by: dbaeumer <1931590+dbaeumer@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix diagnostics pull not working on quick reopen of file Preserve diagnostic pull state after quick document reopen Aug 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Diagnostics pull does not work if file is closed and reopened quickly

2 participants