FIX initializer edit save failures - #2393
Open
hannahwestra25 wants to merge 4 commits into
Open
Conversation
- Add externalError prop to InitializerParametersDialog for inline error display - Make handleSave return boolean (consistent with handleAdd) - Keep edit dialog open when save returns false (edits preserved) - Add tests for new behavior Fixes microsoft#2347 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
- Track save errors per additional initializer - Pass save errors into the edit dialog via externalError - Prevent submit-triggered dialog close requests while save is in progress - Add tests for inline save errors and preserved edits Fixes microsoft#2347 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
- Assign each multiselect checkbox a unique id so label clicks target the correct option - Add a regression test for clicking checkbox label text Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
hannahwestra25
changed the title
…ve-edits-on-save-fail # Conflicts: # frontend/src/components/Initializers/InitializerParametersDialog.test.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2347
Keeps edited initializer values in the dialog when save fails and shows the error inline. Also fixes checkbox label clicks for initializer multiselect parameters.