-
Notifications
You must be signed in to change notification settings - Fork 832
[FEAT] Resolve Key Vault-Backend Environment References and Update .env_example #2363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Victor Valbuena (ValbuenaVC)
wants to merge
31
commits into
microsoft:main
Choose a base branch
from
ValbuenaVC:env-refactor
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
6941013
FEAT Add Key Vault environment resolution
07a85c5
Merge branch 'main' into env-refactor
ValbuenaVC 4e7fa7a
Merge branch 'main' into env-refactor
ValbuenaVC eafe42c
FEAT: Removed recursion for KV lookups
f1deb1f
Merge remote-tracking branch 'refs/remotes/ValbuenaVC/env-refactor' i…
d14821b
FEAT: Added strict mode for KV
de5be15
FIX: Restore ambient-only setup path
dd30926
FEAT: Changed precedence for AKV secrets. No longer raises on both .e…
be956df
FEAT: Refactored precedence order and simplified environment variable…
5304ef8
Merge branch 'main' into env-refactor
ValbuenaVC 2a2d8a8
Merge branch 'main' into env-refactor
ValbuenaVC 9a97358
Merge branch 'main' into env-refactor
ValbuenaVC 8ee9c63
FEAT Simplification refactor
90c3ff9
Merge branch 'env-refactor' of https://github.com/ValbuenaVC/PyRIT in…
8529c9d
FIX: precommit
9d98fb1
FIX: docs
3ecb38d
Merge branch 'main' into env-refactor
ValbuenaVC f3f7ebb
Update doc/getting_started/pyrit_conf.md
ValbuenaVC dc5e133
FIX: docs consistency
7c189b0
Merge branch 'env-refactor' of https://github.com/ValbuenaVC/PyRIT in…
53b06d3
Merge branch 'main' into env-refactor
ValbuenaVC 9fe85a9
FEAT: Fixing .env_example drift
7c0c971
Merge branch 'main' into env-refactor
ValbuenaVC 8d34516
Merge branch 'main' into env-refactor
ValbuenaVC 2063af3
FIX: Remove extra newlines from .env_example
21685dd
Merge branch 'main' into env-refactor
ValbuenaVC e8612b2
FEAT: Addressing latest PR comments
59d36c4
Merge branch 'env-refactor' of https://github.com/ValbuenaVC/PyRIT in…
0d8c5ad
FEAT: env local integratoin test
cfd24ff
FEAT: Update .env_example
47c1a28
Merge branch 'main' into env-refactor
ValbuenaVC File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is the default 500 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's somewhat arbitrary, since
PyritExceptionrequires a status code and 500 seemed like a reasonable default (key vault not reachable for some reason). Do you think it should be changed and/or do you thinkKeyVaultInitializationExceptionshould exist?