[diskann-quantization] Consolidate test directories - #1335
Open
Mark Hildebrand (hildebrandmw) wants to merge 1 commit into
Open
[diskann-quantization] Consolidate test directories#1335Mark Hildebrand (hildebrandmw) wants to merge 1 commit into
Mark Hildebrand (hildebrandmw) wants to merge 1 commit into
Conversation
Mark Hildebrand (hildebrandmw)
requested review from
a team
and
a lite review from Copilot
August 14, 2026 18:05
Copilot started reviewing on behalf of
Mark Hildebrand (hildebrandmw)
August 14, 2026 18:05
View session
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates diskann-quantization’s spherical quantization tests to use a single canonical tests/ directory (removing the legacy test/ path) and relocates the generated baseline JSON fixtures accordingly.
Changes:
- Updated the spherical test baseline path builder to read baselines from
tests/generated/spherical. - Added/relocated generated spherical baseline JSON fixtures under
diskann-quantization/tests/generated/spherical.
Reviewed changes
Copilot reviewed 1 out of 16 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| diskann-quantization/src/spherical/iface.rs | Updates the test baseline path to use tests/ instead of test/. |
| diskann-quantization/tests/generated/spherical/4bit_squared_l2_padding_hadamard.json | Generated spherical baseline fixture under consolidated tests/ directory. |
| diskann-quantization/tests/generated/spherical/4bit_squared_l2_null.json | Generated spherical baseline fixture under consolidated tests/ directory. |
| diskann-quantization/tests/generated/spherical/2bit_squared_l2_double_hadamard.json | Generated spherical baseline fixture under consolidated tests/ directory. |
| diskann-quantization/tests/generated/spherical/2bit_cosine_double_hadamard.json | Generated spherical baseline fixture under consolidated tests/ directory. |
| diskann-quantization/tests/generated/spherical/1bit_squared_l2_double_hadamard.json | Generated spherical baseline fixture under consolidated tests/ directory. |
| diskann-quantization/tests/generated/spherical/1bit_cosine_double_hadamard.json | Generated spherical baseline fixture under consolidated tests/ directory. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1335 +/- ##
==========================================
- Coverage 92.54% 91.54% -1.00%
==========================================
Files 522 522
Lines 99531 99531
==========================================
- Hits 92107 91120 -987
- Misses 7424 8411 +987
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Harsha Simhadri (harsha-simhadri)
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consolidate
testsandtestinto justtests.