Skip to content

[diskann-quantization] Consolidate test directories - #1335

Open
Mark Hildebrand (hildebrandmw) wants to merge 1 commit into
mainfrom
mhildebr/comsolidate
Open

[diskann-quantization] Consolidate test directories#1335
Mark Hildebrand (hildebrandmw) wants to merge 1 commit into
mainfrom
mhildebr/comsolidate

Conversation

@hildebrandmw

Copy link
Copy Markdown
Contributor

Consolidate tests and test into just tests.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates diskann-quantization’s spherical quantization tests to use a single canonical tests/ directory (removing the legacy test/ path) and relocates the generated baseline JSON fixtures accordingly.

Changes:

  • Updated the spherical test baseline path builder to read baselines from tests/generated/spherical.
  • Added/relocated generated spherical baseline JSON fixtures under diskann-quantization/tests/generated/spherical.

Reviewed changes

Copilot reviewed 1 out of 16 changed files in this pull request and generated no comments.

Show a summary per file
File Description
diskann-quantization/src/spherical/iface.rs Updates the test baseline path to use tests/ instead of test/.
diskann-quantization/tests/generated/spherical/4bit_squared_l2_padding_hadamard.json Generated spherical baseline fixture under consolidated tests/ directory.
diskann-quantization/tests/generated/spherical/4bit_squared_l2_null.json Generated spherical baseline fixture under consolidated tests/ directory.
diskann-quantization/tests/generated/spherical/2bit_squared_l2_double_hadamard.json Generated spherical baseline fixture under consolidated tests/ directory.
diskann-quantization/tests/generated/spherical/2bit_cosine_double_hadamard.json Generated spherical baseline fixture under consolidated tests/ directory.
diskann-quantization/tests/generated/spherical/1bit_squared_l2_double_hadamard.json Generated spherical baseline fixture under consolidated tests/ directory.
diskann-quantization/tests/generated/spherical/1bit_cosine_double_hadamard.json Generated spherical baseline fixture under consolidated tests/ directory.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.54%. Comparing base (2bb3a53) to head (f06c542).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1335      +/-   ##
==========================================
- Coverage   92.54%   91.54%   -1.00%     
==========================================
  Files         522      522              
  Lines       99531    99531              
==========================================
- Hits        92107    91120     -987     
- Misses       7424     8411     +987     
Flag Coverage Δ
miri 91.54% <100.00%> (-1.00%) ⬇️
unittests 91.22% <100.00%> (-1.28%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
diskann-quantization/src/spherical/iface.rs 90.19% <100.00%> (-0.19%) ⬇️

... and 44 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants