Skip to content

fix: Forward impression events instead of null events #375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mmustafa-tse wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Forward impression events instead of null events #375

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions ios/RNMParticle/RNMParticle.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -573,6 +573,37 @@ - (void)logCommerceEvent:(JS::NativeMParticle::CommerceEvent &)commerceEvent {
[mpCommerceEvent addProducts:productsArray];
}

if (commerceEvent.impressions().has_value()) {
auto impressionsVector = commerceEvent.impressions().value();
for (size_t j = 0; j < impressionsVector.size(); j++) {
auto impressionStruct = impressionsVector[j];
NSString *listName = impressionStruct.impressionListName();
if (!listName) {
continue;
}
auto productsInImpression = impressionStruct.products();
for (size_t k = 0; k < productsInImpression.size(); k++) {
auto productStruct = productsInImpression[k];
NSMutableDictionary *productDict = [[NSMutableDictionary alloc] init];
if (productStruct.name()) productDict[@"name"] = productStruct.name();
if (productStruct.sku()) productDict[@"sku"] = productStruct.sku();
productDict[@"price"] = @(productStruct.price());
if (productStruct.quantity().has_value()) productDict[@"quantity"] = @(productStruct.quantity().value());
if (productStruct.brand()) productDict[@"brand"] = productStruct.brand();
if (productStruct.couponCode()) productDict[@"couponCode"] = productStruct.couponCode();
if (productStruct.position().has_value()) productDict[@"position"] = @(productStruct.position().value());
if (productStruct.category()) productDict[@"category"] = productStruct.category();
if (productStruct.variant()) productDict[@"variant"] = productStruct.variant();
if (productStruct.customAttributes()) productDict[@"customAttributes"] = productStruct.customAttributes();

MPProduct *product = [self createMPProductFromDict:productDict];
if (product) {
[mpCommerceEvent addImpression:product listName:listName];

@BrandonStalnaker BrandonStalnaker Aug 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If mpCommerceEvent never gets an addImpression this could leave an odd state but it seems unlikely

}
}
}
}

if (commerceEvent.transactionAttributes().has_value()) {
// Create transaction attributes from the struct
auto transactionAttrs = commerceEvent.transactionAttributes().value();
Expand Down
Loading