SP-3332: 200-series deep_coadd_input_summary table tutorial - #198
SP-3332: 200-series deep_coadd_input_summary table tutorial#198ameisner wants to merge 7 commits into
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
| @@ -0,0 +1,668 @@ | |||
| { | |||
There was a problem hiding this comment.
should VisitDetector be changed to visit_detector_table?
also add skyMap to data products and maybe lsst.geom to packages
Reply via ReviewNB
| @@ -0,0 +1,668 @@ | |||
| { | |||
There was a problem hiding this comment.
the intro is maybe a bit light. might benefit from a quick summary of what the user will be doing in the tutorial.
Reply via ReviewNB
| @@ -0,0 +1,668 @@ | |||
| { | |||
There was a problem hiding this comment.
Line #7. input_detectors_to_plot = joined_table[::6]
maybe mention [::6] means we are plotting every 6th data point in the markdown so the 6 is not unexplained
Reply via ReviewNB
| @@ -0,0 +1,668 @@ | |||
| { | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
Is there a specific part of RTN-045 you can point to for this? I'm not currently seeing this in RTN-045, and spot-checking several existing 201-series tutorials within DP2, none have this.
|
hi Aaron, looks good to me. just a couple of comments above. |
2 participants
add new 200-series notebook tutorial for the deep_coadd_input_summary table