Skip to content

DM:53098 : Convert ctrl_bps_htcondor to use htcondor2 - #101

Draft
tcjennings wants to merge 5 commits into
mainfrom
tickets/DM-53098
Draft

DM:53098 : Convert ctrl_bps_htcondor to use htcondor2#101
tcjennings wants to merge 5 commits into
mainfrom
tickets/DM-53098

Conversation

@tcjennings

@tcjennings tcjennings commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

DRAFT WIP
This branch so far is table stakes for migrating to htcondor2.

Todo

  • Validate DagmanConfigurator params
  • Refactor and deprecate "ToE"-related logic

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@codecov

codecov Bot commented Aug 20, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 67.05882% with 56 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.04%. Comparing base (b1bdbe0) to head (57ad5ae).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
python/lsst/ctrl/bps/htcondor/lssthtc.py 47.72% 21 Missing and 2 partials ⚠️
python/lsst/ctrl/bps/htcondor/htcondor_config.py 33.33% 16 Missing ⚠️
python/lsst/ctrl/bps/htcondor/common_utils.py 40.00% 8 Missing and 1 partial ⚠️
python/lsst/ctrl/bps/htcondor/htcondor_service.py 63.63% 7 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #101      +/-   ##
==========================================
- Coverage   85.26%   85.04%   -0.22%     
==========================================
  Files          19       19              
  Lines        4417     4427      +10     
  Branches      463      466       +3     
==========================================
- Hits         3766     3765       -1     
- Misses        575      586      +11     
  Partials       76       76              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@tcjennings
tcjennings force-pushed the tickets/DM-53098 branch 2 times, most recently from dff44eb to 555ac9e Compare August 20, 2026 19:39
- use `htcondor2` imports instead of `htcondor`
- correct patch objects in tests
- refactor `htcondor2`-induced changes
- write a fake ToE for events.
- mark ToE-related classes deprecated
- removes deprecated JobStatus enum in favor of `htcondor.JobStatus`
- pin htcondor to 24|25
- add matrix test for htcondor versions
- add towncrier fragment
- for htcondor 24.0 LTS, use the old ping API
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant