DOC-377: Add OIDC identity source support for Verified Permissions - #848
DOC-377: Add OIDC identity source support for Verified Permissions#848HarshCasper wants to merge 1 commit into
Conversation
Deploying localstack-docs with
|
| Latest commit: |
d246d9d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://47a65971.localstack-docs.pages.dev |
| Branch Preview URL: | https://docs-agent-doc-377.localstack-docs.pages.dev |
|
FYI, it's marking Harsh as the creator of the PR but that is incorrect, it's the agent workflow bot. We need to fix this. |
bentsku
left a comment
There was a problem hiding this comment.
LGTM, one comment about the last bullet point in the Identity Sources part. I think it is more like "in order to use IsAuthorizedWithToken, you need to create an identity source", this is not well said, but I'd like to communicate this intent a bit better?
| - Validates JWT signatures against the issuer's public keys | ||
| - Enforces token expiration (`exp` claim) | ||
| - Extracts principal information and group memberships from token claims | ||
| - Evaluates authorization requests using [`IsAuthorizedWithToken`](https://docs.aws.amazon.com/verifiedpermissions/latest/apireference/API_IsAuthorizedWithToken.html) and [`BatchIsAuthorizedWithToken`](https://docs.aws.amazon.com/verifiedpermissions/latest/apireference/API_BatchIsAuthorizedWithToken.html) |
There was a problem hiding this comment.
note: I think from the sentence above, this is a consequence of "when you create an identity source", but I don't think this is true. By creating an identity source, you can then call IsAuthorizedWithToken, so it's the result, it shouldn't be a bullet point. Does it make sense?
Ah, I didn't realize. I approved, but this is then a comment, I would react differently reviewing an Agent PR vs a Human one, as my comment / intent being it is not very clear. @quetzalliwrites it is also pointing to |
didn't read the whole description and missed it was agent generated. Have a few comments before merge
Summary
This PR updates the LocalStack documentation to reflect the new OIDC identity source support in AWS Verified Permissions, as implemented in localstack/localstack-pro#8072.
Changes
1. Updated Verified Permissions Service Documentation (
src/content/docs/aws/services/verifiedpermissions.mdx)VERIFIEDPERMISSIONS_DISABLE_JWT_VERIFICATIONconfiguration option for local development2. Added Configuration Variable (
src/content/docs/aws/customization/configuration-options.md)Added a new "Verified Permissions" section under "Local AWS Services" with the
VERIFIEDPERMISSIONS_DISABLE_JWT_VERIFICATIONenvironment variable:0(verification enabled)Audit Trail
Research Protocol Followed
Coverage Analysis:
src/data/coverage/verifiedpermissions.jsonCreateIdentitySource,UpdateIdentitySource,GetIdentitySource,DeleteIdentitySource,ListIdentitySources) are marked as implemented withaws_validated: trueIsAuthorizedWithToken,BatchIsAuthorizedWithToken) are fully supportedExisting Documentation:
src/content/docs/aws/services/verifiedpermissions.mdxAWS Documentation Referenced:
Linear Ticket Context:
VERIFIEDPERMISSIONS_DISABLE_JWT_VERIFICATIONto configuration referenceVerification
npm run buildsuccessfully with no errorssrc/content.config.tsagents.mdconventions (direct, instructional, second person, present tense)Confidence Assessment
High Confidence - All information is directly sourced from:
No Gaps or Conflicts - The feature implementation aligns with AWS behavior as documented, and all previously listed limitations regarding OIDC have been addressed by the implementation.
Closes DOC-377
Important
An AI agent generated this pull request. Review all changes before you merge.