Skip to content

fix: correct 'branche' typo to 'branch'/'branches' in repo configs - #802

Merged
BLumia merged 1 commit into
linuxdeepin:masterfrom
wineee:fix
Aug 7, 2026
Merged

fix: correct 'branche' typo to 'branch'/'branches' in repo configs#802
BLumia merged 1 commit into
linuxdeepin:masterfrom
wineee:fix

Conversation

@wineee

@wineee wineee commented Aug 7, 2026

Copy link
Copy Markdown
Member
  • linglong-pica: branche -> branch (single branch)
  • linglong-dbus-proxy, linglong-hub, ddm, linglong, treeland, linglong-loader, linglong-box: branche -> branches (multiple branches)

Summary by Sourcery

Fix repository configuration typos in linuxdeepin JSON repo definitions.

Bug Fixes:

  • Correct misspelled 'branche' field to 'branch' or 'branches' in multiple linuxdeepin repo config files to ensure proper branch configuration resolution.

Chores:

  • Normalize branch-related keys across linuxdeepin repo JSON configs for consistency.

- linglong-pica: branche -> branch (single branch)
- linglong-dbus-proxy, linglong-hub, ddm, linglong, treeland,
  linglong-loader, linglong-box: branche -> branches (multiple branches)
@sourcery-ai

sourcery-ai Bot commented Aug 7, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Standardize repository configuration keys by correcting the typo 'branche' to the correct 'branch'/'branches' across multiple linuxdeepin repo JSON files.

File-Level Changes

Change Details Files
Correct typo in repository branch configuration keys from 'branche' to 'branch'/'branches'.
  • Update linglong-pica repo config to use 'branch' for a single branch entry instead of 'branche'.
  • Update multiple repo configs (linglong-dbus-proxy, linglong-hub, ddm, linglong, treeland, linglong-loader, linglong-box) to use 'branches' for multi-branch definitions instead of 'branche'.
  • Ensure all affected JSON configs remain valid and consistent in structure after key renaming.
repos/linuxdeepin/ddm.json
repos/linuxdeepin/linglong-box.json
repos/linuxdeepin/linglong-dbus-proxy.json
repos/linuxdeepin/linglong-hub.json
repos/linuxdeepin/linglong-loader.json
repos/linuxdeepin/linglong-pica.json
repos/linuxdeepin/linglong.json
repos/linuxdeepin/treeland.json

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot

Copy link
Copy Markdown
Contributor

deepin pr auto review

★ 总体评分:100分

■ 【总体评价】

代码精准修复了多个CI/CD配置文件中的字段拼写错误,逻辑完全正确
修复了可能导致工作流未按预期触发的致命配置缺陷,无任何扣分项

■ 【详细分析】

  • 1.语法逻辑(完全正确)✓

修改涉及8个JSON配置文件,将错误的键名branche修正。其中7个包含多分支的文件修正为复数形式brancheslinglong-pica.json因仅包含单分支master而精准修正为单数形式branch。修正后的键名能够被上游工作流分发工具正确解析。
建议:保持现有的配置规范,后续新增仓库配置时注意单复数形式的正确使用。

  • 2.代码质量(符合规范)✓

本次修改属于纯粹的拼写错误修复,去除了配置文件中的无效字段,提高了配置文件的可读性和有效性,完全符合JSON配置规范及项目工作流管理标准。
建议:建议在CI/CD配置中心引入JSON Schema校验,在提交前自动拦截此类拼写错误。

  • 3.代码性能(无性能问题)✓

修改内容为静态JSON配置文件的键名替换,不涉及运行时计算、资源分配或系统调用,对系统性能无任何影响。
建议:无

  • 4.代码安全(存在0个安全漏洞)✓

漏洞对比统计:新增漏洞 0 个,减少漏洞 0 个,持平 0 个
本次修改仅为配置文件键名字符串的替换,不涉及权限变更、敏感信息暴露、命令注入或路径遍历等安全风险面,配置目标路径和源路径均保持合法且固定。
建议:无

■ 【改进建议代码示例】

--- a/repos/linuxdeepin/linglong-pica.json
+++ b/repos/linuxdeepin/linglong-pica.json
@@ -14,7 +14,7 @@
     "dest": "linuxdeepin/linglong-pica/.github/workflows/call-clacheck.yml"
   },
   {
-    "branche": [
+    "branch": [
       "master"
     ],
     "src": "workflow-templates/call-commitlint.yml",

@deepin-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BLumia, wineee

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BLumia
BLumia merged commit cba9eaf into linuxdeepin:master Aug 7, 2026
6 checks passed
@wineee
wineee deleted the fix branch August 7, 2026 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants