Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds environment-driven configuration for the CloudTty (cloud shell) container image, and updates the default image tag to the newer version while keeping existing behavior via sane defaults.
Changes:
- Introduces
TTY_IMAGE_REPOSITORYandTTY_IMAGE_TAGenvironment validators with defaults (linode/apl-tty:1.2.8). - Updates
CloudTtyto accept an injected image config and uses it when creating the TTY Pod. - Wires
OtomiStack.getCloudTty()to constructCloudTtyusing the validated env values and updates tests accordingly.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/validators.ts | Adds env validators for TTY image repository/tag with defaults. |
| src/tty.ts | Makes TTY image configurable via constructor-injected config and uses it in Pod spec. |
| src/tty.test.ts | Updates tests to pass the new TtyConfig and asserts the configured image string. |
| src/otomi-stack.ts | Passes env-derived TTY image config into the CloudTty instance. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example values to test