Skip to content

feat: upgrade tty image and allow for configuration through env - #1063

Open
merll wants to merge 1 commit into
mainfrom
APL-2071
Open

feat: upgrade tty image and allow for configuration through env#1063
merll wants to merge 1 commit into
mainfrom
APL-2071

Conversation

@merll

@merll merll commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Example values to test

kind: AplApp
metadata:
    name: otomi-api
spec:
    _rawValues:
        image:
            pullPolicy: Always
            repository: docker.io/linode/apl-api
            tag: APL-2071
        env:
            TTY_IMAGE_REPOSITORY: mirror.registry.linodelke.net/docker/linode/apl-tty
            TTY_IMAGE_TAG: 1.2.8

@merll
merll requested a review from ferruhcihan as a code owner August 12, 2026 14:47
Copilot AI lite review requested due to automatic review settings August 12, 2026 14:47
@merll
merll requested a review from dennisvankekem as a code owner August 12, 2026 14:47

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds environment-driven configuration for the CloudTty (cloud shell) container image, and updates the default image tag to the newer version while keeping existing behavior via sane defaults.

Changes:

  • Introduces TTY_IMAGE_REPOSITORY and TTY_IMAGE_TAG environment validators with defaults (linode/apl-tty:1.2.8).
  • Updates CloudTty to accept an injected image config and uses it when creating the TTY Pod.
  • Wires OtomiStack.getCloudTty() to construct CloudTty using the validated env values and updates tests accordingly.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
src/validators.ts Adds env validators for TTY image repository/tag with defaults.
src/tty.ts Makes TTY image configurable via constructor-injected config and uses it in Pod spec.
src/tty.test.ts Updates tests to pass the new TtyConfig and asserts the configured image string.
src/otomi-stack.ts Passes env-derived TTY image config into the CloudTty instance.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants