Fix uniffi feature breaking postgres/migration integration tests - #1052
Open
juliusjulyp wants to merge 1 commit into
Open
Fix uniffi feature breaking postgres/migration integration tests#1052juliusjulyp wants to merge 1 commit into
juliusjulyp wants to merge 1 commit into
Conversation
Signed-off-by: julypjulius <julypjulius@gmail.com>
|
I've assigned @tnull as a reviewer! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
cargo test --all-featuresfails to compiletests/integration_tests_postgres.rsand
tests/integration_tests_migration.rswith typemismatches (
Arc<NodeEntropy>expected,NodeEntropyfound;Vec<u8>expected,
[u8; 64]found;NodevsArc<Node>).Cause
The
uniffifeature changes the public shape ofNodeEntropy,Node, andrelated builder methods for FFI — wrapping return types in
Arc<T>and switching
NodeEntropy::from_seed_bytesto takeVec<u8>instead of afixed
[u8; 64]array.Fix
Both files now follow the same
#[cfg(feature = "uniffi")]/#[cfg(not(feature = "uniffi"))]pattern similarto
tests/integration_tests_rust.rsandtests/common/mod.rsTesting
cargo test --features postgres --test integration_tests_postgres—3/3 passing, against local Postgres instance
Open to feedback if a different approach is preferred — e.g. expanding CI
coverage to catch this combination going forward, in addition to or instead
of this fix