Fix queue release verification outside a checkout - #2
Merged
Conversation
There was a problem hiding this comment.
VERDICT: CLOSE
- PR metadata / head branch
codex/TASK-1175-release-verifier-fix— exact symptom: the PR claimsTASK-1175, but the authoritative task is “Animus daemon: five-slot generation-fenced coding scheduler and durable leases”, targetslaunchapp-dev/animus-cli.gitatmain, and requires durable generation-fenced scheduler/lease work; this PR instead changes only.github/workflows/release.ymland.github/workflows/verify-release.ymlinlaunchapp-dev/animus-queue-postgres. This is an incompatible repository/task-generation collision, so the diff cannot satisfy its originating task. REQUIRED CHANGE: close this misattributed PR; if the release-verifier fix is still desired, create or identify a distinct task owned bylaunchapp-dev/animus-queue-postgres, then reopen the same minimal workflow edits from a branch named for that task rather thanTASK-1175. Verify by fetching the replacement task and confirming itsgit_repo, title/acceptance criteria, and branch task ID all matchlaunchapp-dev/animus-queue-postgres; then run theVerify Existing Releaseworkflow against an existing immutable release and expect the tag/release validation plus all three archive/checksum pairs to pass.
What is good: the actual workflow edits are small and internally coherent—the explicit --repo "${GITHUB_REPOSITORY}" arguments address gh execution without checkout-derived repository context, and the verifier is read-only. The blocker is provenance and task ownership, not unnecessary complexity in those edits.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v0.2.0 release published all six assets, but its post-publish check failed because the publish job has no checkout and gh release download could not infer a repository.
Fixes:
The published v0.2.0 assets were also downloaded independently and all three archive hashes match their bound checksum files.