refactor(mcp): route workflow launches through services

[Shooksie]

Summary

• route workflow run, run-multiple, and execute through typed in-process application services
• preserve structured workflow input, vars, runner overrides, actor scope, and idempotency keys without argv serialization
• retain legacy input_json compatibility with typed validation and standard batch stop/continue envelopes
• remove the now-unused generic child-CLI batch executor

Verification

• cargo check -p orchestrator-cli --tests
• cargo test -p orchestrator-cli (all unit, binary, and integration suites passed)

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
animus-docs	Ready	Preview, Comment	Jul 29, 2026 3:14pm

[Shooksie]

Draft review:

The typed in-process workflow-launch direction is coherent and preserves structured input, actor scope, runner overrides, and idempotency rather than round-tripping through argv. It is not ready to merge yet:

1. Rebase onto current main (which now includes #361-#365); GitHub reports this head as conflicting.
2. Fix the failing clippy diagnostic at ops_workflow/mod.rs:664 (manual_is_variant_and / use Option::is_none_or or an equally clear equivalent).
3. Rerun the full workspace checks on the rebased merge result, especially the MCP workflow run/execute/batch tests.

Keep this draft until the rebased head is mergeable and all required checks are green.

[animus-launchapp-gitprovider]

VERDICT: CHANGES REQUESTED

1. crates/orchestrator-cli/src/services/operations/ops_workflow/mod.rs:664 — actor.tenant_id.as_deref().map(str::trim).filter(|value| !value.is_empty()).is_none() triggers the required Clippy gate (manual_is_variant_and), and both current clippy check runs are failing. REQUIRED CHANGE: replace this chain with the direct Option predicate Clippy requests (for example, actor.tenant_id.as_deref().is_none_or(|value| value.trim().is_empty())) while preserving the surrounding rejection of blank tenant IDs. Verify with cargo clippy -p orchestrator-cli --tests -- -D warnings; it must exit successfully, and the GitHub clippy checks for the updated head must be green.

The typed in-process workflow-launch direction is otherwise strong: it removes argv serialization while preserving structured input, actor scope, runner overrides, idempotency, and explicit batch behavior.