Validate sprint7 solver input bounds - #80
Closed
krotname wants to merge 1 commit into
Closed
Conversation
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 692189eefb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Owner
Author
|
Закрываю как superseded by #116: изменения перенесены в одну проверенную ветку, все review findings учтены; локальный mvn verify прошёл полностью. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Motivation
nto triggerNegativeArraySizeException/OutOfMemoryErrorand permitting integer overflow when accumulating point totals.Description
MAX_GAMESandMAX_TOTALlimits and validatedpoints.lengthand eachpointbefore use inEqualSums, and changed the accumulator to alongto avoid overflow when computing the bitmaptarget(then cast toint).EqualSums.run()to validatenand per-point values read from stdin to avoid negative sizes or oversized allocations.MAX_LINE_LENGTHand pre-checks inLevenshteinDistance.solve()and changedFastIn.nextLine()tonextLine(int maxLength)which enforces a maximum line length and caps buffer growth to prevent unbounded buffering.nextLine(MAX_LINE_LENGTH)for both input lines inLevenshteinDistance.Testing
mvn testand the full test suite completed successfully after the changes.javac -d /tmp/ckj_classes src/main/java/algorithms/sprint7/EqualSums.java src/main/java/algorithms/sprint7/LevenshteinDistance.javaand exercised them via the CLI to confirm expected behavior for normal inputs.nor overly largen/point totals inEqualSumsreturn an IO/argument error rather thanNegativeArraySizeException/OutOfMemoryError, and overly long lines toLevenshteinDistanceproduce anInput line is too longerror instead of unbounded OOM or excessive CPU.java -cp /tmp/ckj_classes algorithms.sprint7.EqualSumsandalgorithms.sprint7.LevenshteinDistance).Codex Task