docs: note that tests/smoketest.sh is not run by any CI workflow - #715
Open
UgaTheDev wants to merge 1 commit into
Open
docs: note that tests/smoketest.sh is not run by any CI workflow#715UgaTheDev wants to merge 1 commit into
UgaTheDev wants to merge 1 commit into
Conversation
docs/ci.md pointed at tests/smoketest.sh without saying whether CI runs it. It doesn't: smoke.yaml runs tox -e py3-smoke, which only invokes pytest tests/smoke, never smoketest.sh. The script still covers axes the pytest matrix doesn't (flash-attention, Granite, FSDP+LoRA), so it's orphaned rather than redundant. Notes that explicitly and points at instructlab#705 where the consolidation question is still open. Ref: instructlab#705 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: Kush Zingade <kush.zingade@gmail.com>
|
Warning Review limit reachedNext included review available in 59 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs/ci.mdpoints attests/smoketest.shunder "Smoke tests" withoutsaying whether CI runs it. It doesn't:
smoke.yamlinvokestox -e py3-smoke, which (tox.ini) runspytest tests/smoke, nevertests/smoketest.sh. The script still covers axes the pytest matrix doesn't(flash-attention on/off, Granite on/off, FSDP+LoRA), so it's not redundant —
just orphaned and easy to mistake for something CI already checks.
This adds one sentence making that explicit and pointing at #705, where the
consolidation question (fold
smoketest.sh's cases intotest_training_feature_matrix, or delete it) is still open and needs amaintainer decision — actually reconciling the two test surfaces is a bigger
change than a docs PR should carry.
Originally flagged in #705 (comment from 2026-07-29): "There's a second smoke test nobody runs... No workflow calls it anymore, since
smoke.yamlinvokestox -e py3-smokewhich only points attests/smoke/. It's dead as far as CI goes but still checked in and still exercising real coverage."One-line diff,
docs/ci.mdonly.