chore: fill derivable placeholders, drop false ARCHITECTURE, surface the rest - #61
Conversation
…the rest
Estate top-up pass. Three separate things, none of which invents a value.
FILLED — every token with a single mechanical answer: OWNER, REPO, FORGE,
PROJECT, PACKAGE_NAME, PROJECT_NAME, AUTHOR, AUTHOR_EMAIL, CONDUCT_EMAIL,
AUTHOR_FIRST/LAST/INITIALS, CURRENT_YEAR, CURRENT_DATE, DATE, MAIN_BRANCH.
Identity comes from the git remote, dates from the clock, project name from the
README H1 where there is one.
Deliberately NOT filled, because more than one defensible answer exists and a
confident wrong value is worse than a visible gap: SECURITY_EMAIL (two competing
addresses are in use across the estate), RESPONSE_TIME, CONDUCT_TEAM (which
substitutes into "a {{CONDUCT_TEAM}} member", not English), WEBSITE,
PROJECT_DESCRIPTION, LANG_STACK.
DELETED — ARCHITECTURE.md, where it is byte-identical to the 346-copy estate
boilerplate (blob 607e3d8c). Those 33 lines describe a src/ tests/ docs/
scripts/ config/ tree that this repo does not have, so the file is not merely
uninformative, it is wrong. Genuinely written ARCHITECTURE files are matched by
hash and left alone. No file beats a confidently false one.
CODEOWNERS — rewritten to the solo form mandated by
hyperpolymath/standards CODEOWNERS-POLICY.adoc Rule 1, which forbids a catch-all
line where the only owner is the sole maintainer. The estate's own
templates/CODEOWNERS contradicts that policy; the policy is versioned, dated and
resolves standards#55, so it wins. Files naming a genuine co-owner are Rule 2
and are untouched. Note @hyperpolymath and @metadatastician are the same person,
so a file naming the other account is a copy artifact that silently routed
review requests to the wrong account.
SURFACED — REQUIRES_INITIALISATION.md, and a priority action in
0-AI-MANIFEST.a2ml. Tokens that need a decision no script can make are left
visibly unfilled rather than faked or quietly deleted. The marker says what each
one is, which files it belongs in, why it was not done already, and that it must
be deleted only once the work is genuinely finished.
|
![gitar-bot[bot]](https://avatars.githubusercontent.com/in/827041?s=60&v=4){kind=small}
| // Copyright (c) Jonathan D.A. Jewell <j.d.a.jewell@open.ac.uk> | ||
| // Template: QUICKSTART-MAINTAINER.adoc — packaging, deploying, and maintaining | ||
| // Replace rsr-template-repo, {{PACKAGE_NAME}}, {{DEPS}} with actuals | ||
| // Replace rsr-template-repo, krl, {{DEPS}} with actuals |
There was a problem hiding this comment.
💡 Quality: PACKAGE_NAME filled but project name 'rsr-template-repo' left literal
This edit replaced {{PACKAGE_NAME}} with krl in install paths, but the file still hard-codes the template's own name rsr-template-repo in the title (line 5), overview (line 11) and the clone/build commands (lines 22-24, 50). The result is contradictory guidance: maintainers are told to build/clone rsr-template-repo yet install artefacts under krl. The edited comment on line 4 ("Replace rsr-template-repo, krl, {{DEPS}} with actuals") even lists the now-resolved value krl as something still to replace. Replace the remaining rsr-template-repo literals with krl and drop krl from the replace-list comment.
Was this helpful? React with 👍 / 👎
|
Note Automatic reviews are paused because your trial's included automatic processing has been used for this period. Upgrade now, or comment "Gitar review" to run a review anytime. Code Review 👍 Approved with suggestions 0 resolved / 1 findingsAutomated estate top-up replacing derivable placeholders and removing boilerplate architecture documentation. Update PACKAGE_NAME across install paths, but ensure the hard-coded template name 'rsr-template-repo' is also updated in the title, overview, and build commands.
💡 Quality: PACKAGE_NAME filled but project name 'rsr-template-repo' left literal📄 QUICKSTART-MAINTAINER.adoc:4 📄 QUICKSTART-MAINTAINER.adoc:5 📄 QUICKSTART-MAINTAINER.adoc:11 📄 QUICKSTART-MAINTAINER.adoc:22 📄 QUICKSTART-MAINTAINER.adoc:23 📄 QUICKSTART-MAINTAINER.adoc:50 This edit replaced {{PACKAGE_NAME}} with 🤖 Prompt for agentsOptionsDisplay: compact → Showing less information. Comment with these commands to change the behavior for this request:
Important Your trial ends in 5 days — upgrade now to keep code review, CI analysis, auto-apply, custom automations, and more. Was this helpful? React with 👍 / 👎 | Gitar |
There was a problem hiding this comment.
Configure merge blocking · Maintainers can dismiss this review.
|
|
1 participant
Automated estate top-up. Nothing here invents a value.
Filled — every token with one mechanical answer (owner, repo, forge, author, dates, project name, main branch). Identity from the git remote, dates from the clock, name from the README H1.
Not filled, on purpose —
SECURITY_EMAIL(two competing addresses exist in the estate),RESPONSE_TIME,CONDUCT_TEAM(substitutes into "a {{CONDUCT_TEAM}} member", which is not English),WEBSITE,PROJECT_DESCRIPTION,LANG_STACK. More than one defensible answer exists, and a confident wrong value is worse than a visible gap.Deleted —
ARCHITECTURE.mdwhere it is byte-identical to the 346-copy estate boilerplate (blob607e3d8c). Those 33 lines describe asrc/ tests/ docs/ scripts/ config/tree this repo does not have. Matched by hash, so a genuinely written ARCHITECTURE can never be caught by it.CODEOWNERS — the solo form from
standards/CODEOWNERS-POLICY.adocRule 1, which forbids a catch-all where the only owner is the sole maintainer.templates/CODEOWNERScontradicts that policy; the policy is versioned, dated and resolvesstandards#55, so it wins. Genuine co-owners (Rule 2) are untouched.Surfaced —
REQUIRES_INITIALISATION.mdplus a priority action in0-AI-MANIFEST.a2ml, listing every remaining token, what it means, which files it belongs in, why it was not done already, and that it is to be deleted only when the work is genuinely complete.Built from a fresh clone of
origin/main, never a local checkout — several of those are dirty and hold unpushed commits.🤖 Generated with Claude Code