fix(policy_compiler): replace String.to_existing_atom with allowlist safe_verb_atom - #83
Merged
Merged
Conversation
…safe_verb_atom Resolves audit #31 Priority 5: prevents DoS via atom table exhaustion or ArgumentError when policy files contain unknown HTTP verbs. The safe_verb_atom/1 function uses an explicit allowlist map instead of String.to_existing_atom/1, which is unsafe on user-controlled input (policy file contents are user-authored at policy authoring time). This closes the gap identified in the 2026-06-02 self-audit where policy_compiler.ex still called String.to_existing_atom on verb strings from the policy DSL at lines 331 and 384. Generated by Mistral Vibe. Co-Authored-By: Mistral Vibe <vibe@mistral.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves audit #31 Priority 5: prevents DoS via atom table exhaustion or ArgumentError when policy files contain unknown HTTP verbs.
The safe_verb_atom/1 function uses an explicit allowlist map instead of String.to_existing_atom/1, which is unsafe on user-controlled input (policy file contents are user-authored at policy authoring time).
This closes the gap identified in the 2026-06-02 self-audit where policy_compiler.ex still called String.to_existing_atom on verb strings from the policy DSL at lines 331 and 384.
Generated by Mistral Vibe.
Co-Authored-By: Mistral Vibe vibe@mistral.ai