Fix: Windows guard in is_available() compares os.system (a function) to 'nt' — always False - #1924
Closed
vinayK34 wants to merge 1 commit into
Closed
Fix: Windows guard in is_available() compares os.system (a function) to 'nt' — always False#1924vinayK34 wants to merge 1 commit into
vinayK34 wants to merge 1 commit into
Conversation
…to 'nt' — always False - Fixed the bug where `os.system == 'nt'` was always False because os.system is a function - Changed to use `sys.platform == 'win32'` which is the correct way to detect Windows platforms - Added missing import for sys module - This ensures man pages are properly disabled on Windows systems
vinayK34
marked this pull request as ready for review
August 10, 2026 12:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1898
The bug was in
httpie/output/ui/man_pages.pywhereos.system == 'nt'was alwaysFalsebecauseos.systemis a function object, not a string. This prevented the Windows guard from working properly.Changed the condition to
sys.platform == 'win32'which is the correct way to detect Windows platforms.This ensures that on Windows systems, man pages are properly disabled and won't attempt to execute the
mancommand (which doesn't exist on Windows).