fix(har): support UPSTREAM registry creation, --level scoping in firewall_scan, and NuGet lockfiles - #148
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes three Artifact Registry defects found during CLI testing:
create registry --type UPSTREAMhad no way to supply auth/source config.Added
--source,--url,--auth-type,--username,--secret-identifier,--access-key,--secret-key-identifier,--remote-url-suffix, and--firewall-modeflags, wired into the existingconfig.*body_params viadot-path nesting (same declarative mechanism already used for
config.type).execute registry:firewall_scan --level account|orgwas silently ignored.firewall_scanis aworkflow-handler command, so it never went throughcallEndpointFull(the only place--levelwas previously applied). Added anapplyLevelScopehelper that mirrors that scope-stripping logic and wired itinto both firewall_scan handlers. Also fixed a related bug found while
verifying this live:
getRegistryUUID's raw HTTP call was missing theaccountIdentifierquery param that the generic client injects automaticallyfor all other endpoint-routed requests, which made account-level lookups 404
even after the scope fix.
execute registry:firewall_scan --lockfile packages.lock.json(NuGet)was rejected as an unsupported file format. Added a case to
parseLockFilethat reuses the existing
nugetParseLockFileparser (already used by thedotnet restoreauto-flow), so no new parsing logic was needed.