Re-extract app-bundle overlay at fork v1.18.10-amicode.16 (repairs the #513 drift break) - #531
Merged
Merged
Conversation
Repairs the #513 drift-gate break on main: the overlay hand-edit is superseded by the fork's canonical question-default implementation (opencode#232, included in the .16 tag). 80 files added, 63 changed — the full UI wave (workspace engine, retheme, status-dot semantics, theme fixes). Round-trip verified: all 502 files byte-identical to the tag; drift gate PASS. Closes #530. Fork tag tracked by harmoniqs/opencode#238.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (149)
📝 WalkthroughWalkthroughThis PR re-extracts the app bundle at the Amicode fork release. It adds application dialogs, session state handling, WSL support, core location and session contracts, new UI components and themes, solver switching, regression tests, and extension styling updates. ChangesAmicode release and application integration
Estimated code review effort: 5 (Critical) | ~120 minutes Sequence Diagram(s)sequenceDiagram
participant User
participant SolverToggle
participant StatusPopover
participant SolverSwitchBanner
participant Server
User->>SolverToggle: Select Piccolo
SolverToggle->>StatusPopover: Request solver selection
StatusPopover->>SolverSwitchBanner: Begin switch narration
StatusPopover->>Server: POST /amicode/solver-mode
Server-->>StatusPopover: Connection state changes
SolverSwitchBanner-->>User: Render phase status
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Aligns the vendored binary with the app-bundle overlay pin and the frozen server binary (same fork revision, 77bb1c8b7). Asset hashes recorded from the release.
The contract suite's self-tracking check caught the pin bump — goldens re-recorded via scripts/record_amicode_fixtures.mjs (71 entries).
The parity suite caught the pin bump's second-order effect: the fork's re-theme wave (opencode#235) restyled all seven builtin widgets; the extension's copies lagged. Synced verbatim from the fork's widgets-src — the fork binary is the parity source of truth.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #530.
The overlay hand-edit from #513 (session-question-dock.tsx) is superseded by the fork's canonical implementation (opencode#232, in the .16 tag) — same feature, fork-canonical code. 80 files added, 63 changed (the UI wave: workspace engine, retheme, status-dot semantics, theme fixes); round-trip verified byte-identical to the tag; drift gate PASS locally.
Second commit (pending): the vendored-binary lock bump (opencode.lock.json .14 → .16) once the fork release assets finish building — then CI's full matrix can go green.
Fork tag: harmoniqs/opencode#238.
Summary by CodeRabbit
New Features
Bug Fixes
Tests