Doctor v2: surface inventory, injectable probes, JSON contract, verdict-matrix fixtures - #529
Draft
aarontrowbridge wants to merge 3 commits into
Draft
Doctor v2: surface inventory, injectable probes, JSON contract, verdict-matrix fixtures#529aarontrowbridge wants to merge 3 commits into
aarontrowbridge wants to merge 3 commits into
Conversation
…ll tracer (#525) surfaces.ts: server-binary, extension, vendored-binary, staged-skills, agent-cards-global, agent-cards-staging probes over an injectable SurfaceContext. Verdicts by version string or content digest only — never mtime; version-sorted 'newest' selection; probes degrade individually. Hermetic current-world fixture: fake binaries print pinned far-future build dates, git fixtures carry pinned commit dates, remotes are local bare repos.
…ells (#525) server-binary's three stale mechanisms as separate fixtures (version-stale, running≠frozen, server-down); per-surface stale cells; tampered-sidecar integrity-failure; unknown ×6 (dead-remote stubs, missing-local-source); degradation proof — every source dead still yields six records.
…ing (#525) - schemas/doctor-report.schema.json: the committed machine contract (surfaces minItems 6; required surface/version/verdict/evidence), itself in canonical form; doctor_schema.ts validates against it (zero new deps, the vault-card minimal-engine pattern). - doctor.ts: doctorReport(argv) parses --json + the seven injectable flags; composes v1's binding diagnosis with the surface inventory; v1's rendered/exit contract preserved verbatim (report GAINS a surfaces section; --json emits canonical JSON, surfaces only). - amico.ts: the doctor case passes argv and prints json when present. - Fixture world extracted to test/helpers.ts (shared by the unit + CLI suites); platform dir derived from the live platform (runner-portable); hermetic discoverRunning default (a forgotten stub reads server-down, never the real machine's process). - CLI end-to-end: amico doctor --json through the built bundle emits the canonical contract; human output keeps the v1 table + surfaces section. - test/fixtures/surfaces/README.md: the authorship-split record (implementer cells here; reviewer adversarial variants listed).
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #525.
The fleet-dev-tools keystone (spec-20260823-094507, D1): six surface records with four-verdict staleness logic — every judgment by version string or content digest, never mtime. Injectable roots + running-binary stub make the 25-test verdict matrix fully hermetic (fake binaries, pinned dates, real git fixtures with local remotes). The committed JSON Schema (minItems 6) + canonical round-trip is the machine contract the panel (#527) and watchdog consume. Doctor v1's studio-binding checks untouched; the report gains a surfaces section.
Typecheck clean; the amico-run suite is 1146 passed with 2 failures proven pre-existing at base e308a45 (both read real machine state — verified in a detached base worktree; details in the notes). Zero new dependencies.
Part of #524.