Mode cards: autodev authored, autoresearch re-pointed, spine parity, deployment script - #522
Merged
Conversation
… spine parity, deploy script (#501) Both mode cards embed the shared director spine between literal DIRECTOR-SPINE v1 markers (one pair per card): the loop, the four core clauses, and the ledger discovery rule quoted verbatim from the director-core skill. The parity suite (mode_cards.test.ts) enforces marker-pair count, byte-identity, the 200-byte floor, the nine-keyword content floor (whole-word, case-insensitive, each in a sentence of >= 8 words), correctness-by-containment against a committed fixture copy of the skill (byte-checked against the live mount when present), frontmatter boot fields, and the zero-blocklist grep. deploy-agents.mjs (manual operator action, never CI) copies both cards to staging + global config, verifies byte-equality, and emits a source-digest receipt.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
📝 WalkthroughWalkthroughAdds the shared ChangesDirector modes
Estimated code review effort: 3 (Moderate) | ~20 minutes ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #501.
The two mode cards at packages/extension/agents/ with the shared DIRECTOR-SPINE v1 block (byte-identical in both — the parity test enforces it, and the ledger discovery rule is quoted verbatim from the merged director core, containment-checked). The parity suite (12 tests): marker-pair count, byte-identity, 200-byte floor, the nine-keyword content floor with ≥ 8-word sentences, verbatim containment against the director-core fixture (byte-checked against the live canonical mount), boot fields, blocklist. The deployment script (deploy-agents.mjs): manual operator action — copies to staging + global config with sha256 verification and a source-digest receipt; exercised against temp destinations only in this slice; the receipt of record comes from the parent's real deployment run.
Full suite 105 files green; typecheck clean. Part of #497 — the last code slice of the two-modes protocol layer before #502 (dual-harness suite).
Summary by CodeRabbit