Naming records: glossary entries + blocklist fixture - #520
Merged
Conversation
…t fixture (#500) The spec's naming_record_complete criterion, amicode side: the six locked terms (director, autoresearch, autodev, campaign, gate pack, mode) enter the CONTEXT.md glossary under Agentic work, each definition opening with the spec's head phrase verbatim, with Avoid lines where the naming table implies them (director: conductor; autodev: autobuild; campaign: copilot sessions; mode: surface conflation). The committed blocklist fixture carries both tables — D4's five proprietary strings and the banned names (conductor, autobuild) — and naming_records.test.ts pins term presence, head-phrase containment, the Avoid lines, copilot-as-zeroth, and the fixture's shape, keeping the six entries free of blocklisted strings. The amico CONTEXT.md companion lines are a cross-repo PR owned by the parent (#497); this slice tests amicode-side only.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughAdded six autonomous-work glossary definitions to ChangesNaming records
Estimated code review effort: 2 (Simple) | ~10 minutes ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #500.
The six locked terms (director, autoresearch, autodev, campaign, gate pack, mode) in CONTEXT.md's ## Language → Agentic work, head phrases matching the spec's naming table (pinned by the test), Avoid lines for director/autodev/campaign/mode; the blocklist fixture at packages/extension/protocol-blocklist.json (proprietary_strings + banned_names); naming test 7/7 green, typecheck clean, additive-only glossary diff.
The amico CONTEXT.md companion line follows as a cross-repo PR from this issue (parent-owned). Part of #497.
Summary by CodeRabbit
Documentation
Tests