Handoff seeds: issue/hypothesis schemas, templates, round-trip corpus - #519
Merged
Conversation
…dversarial corpus (#499) Typed cross-campaign handoff seeds per spec-20260822 D3 / handoff_roundtrip_pass: - committed JSON Schemas (handoff-seeds/): issue seed (title, motivation, evidence pointers that must resolve, suggested_repo, suggested_tier; kind const "issue") and hypothesis seed (observation, evidence, suggested_experiment; kind const "hypothesis"), both additionalProperties:false so a kind/field-set masquerade is refused mechanically - committed render templates + src render/extract: issue seed renders the write-an-issue decision surface, hypothesis seed renders the vault hypothesis card; extractors re-extract the full declared field set (field-equal round-trip over the committed corpus) - evidence pointers resolve at validation time against a root — dead pointers are refused, not warned, with the violated JSON-Pointer path named - fixture corpus: 4 valid (2 per kind) + 4 adversarial (dead pointer, both masquerade directions, missing required field) + fixture-local evidence root - zero new dependencies (yaml + node builtins); zero blocklisted proper nouns in committed slice files (grep-tested)
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (27)
📝 WalkthroughWalkthroughAdded typed issue and hypothesis handoff seeds with schemas, templates, validation, rendering, extraction, committed fixtures, and comprehensive round-trip and adversarial tests. ChangesHandoff seed protocol
Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)sequenceDiagram
participant Seed as HandoffSeed
participant Validator as SeedValidator
participant Renderer as SeedRenderer
participant Artifact as MarkdownArtifact
participant Extractor as SeedExtractor
Seed->>Validator: validate fields and evidence
Validator-->>Renderer: return valid seed
Renderer->>Artifact: render YAML and Markdown
Artifact->>Extractor: provide rendered artifact
Extractor-->>Seed: return extracted typed seed
``
</details>
<!-- walkthrough_end -->
<!-- finishing_touch_checkbox_start -->
<details>
<summary>✨ Finishing Touches</summary>
<details>
<summary>📝 Generate docstrings</summary>
- [ ] <!-- {"checkboxId":"7962f53c-55bc-4827-bfbf-6a18da830691"} --> Create stacked PR
- [ ] <!-- {"checkboxId":"3e1879ae-f29b-4d0d-8e06-d12b7ba33d98"} --> Commit on current branch
</details>
<details>
<summary>🧪 Generate unit tests (beta)</summary>
- [ ] <!-- {"checkboxId": "f47ac10b-58cc-4372-a567-0e02b2c3d479", "radioGroupId": "utg-output-choice-group-unknown_comment_id"} --> Create PR with unit tests
- [ ] <!-- {"checkboxId": "6ba7b810-9dad-11d1-80b4-00c04fd430c8", "radioGroupId": "utg-output-choice-group-unknown_comment_id"} --> Commit unit tests in branch `499-handoff-seeds`
</details>
</details>
<!-- finishing_touch_checkbox_end -->
<!-- tips_start -->
---
<sub>Comment `@coderabbitai help` to get the list of available commands.</sub>
<!-- tips_end -->
|
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #499.
Typed cross-campaign handoffs per the spec's D3: issue-seed and hypothesis-seed JSON Schemas + rendering templates (write-an-issue decision surface; hypothesis card) committed at packages/extension/handoff-seeds/, render/extract functions in src/handoff_seeds.ts (self-contained mini validator — sibling #496 not on this branch), 4 valid + 4 adversarial fixtures (dead evidence pointers, both masquerade directions, missing required) — 19 tests green, typecheck clean, zero new dependencies. Committed-contract sync asserted (schemas/templates are load-bearing, not decorative).
Part of #497.
Summary by CodeRabbit
New Features
Tests