Gate-pack fixtures: research + dev packs as schema'd TOML with mapping tests - #518
Merged
Conversation
…ith mapping-completeness tests (#498) Gate packs as typed data, not prose: the research pack (5 phases, 8 gates, hypothesizer/experimenter/analyzer, experiment-note + ledger-delta closing, issue-seed handoff) extracted from the live director research protocol, and the dev pack (3 phases, 5 gates, worktree-bound no-merge implementer, landed-delta closing, hypothesis-seed handoff) extracted from the issue-DAG walk. The suite in test/gate_packs.test.ts is the spec's gate_pack_mapping_complete criterion: pack schema with kind vocabularies, forward + reverse mapping completeness, non-triviality floors, unique gate names, and pairwise-distinct procedures under normalized-text equality. Parses via smol-toml (already a devDependency).
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughAdded schema'd TOML contracts for research and development gate packs. Added Vitest specifications that validate fixture structure, mapping completeness, non-triviality, distinct procedures, protocol content, closing artifacts, and handoffs. ChangesGate-pack contracts
Estimated code review effort: 3 (Moderate) | ~25 minutes ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #498.
Both gate packs as typed TOML data (packages/extension/gate-packs/): the research pack (8 gates — the five named in the issue plus ledger-currency, probe-boundary, checkout-claim from the live protocol) and the dev pack (5 gates), with the mapping-completeness suite — 57 tests green, forward+reverse checks, all floors (≥ 3 phases, ≥ 5 gates, ≥ 1 per kind, unique names, pairwise-distinct procedures), kind vocabulary enforced. Typecheck clean; smol-toml was already a devDep (no churn).
Gates as data is what the campaign layer consumes (telaio#20's mapping) and what #502's dual-harness suite polices. Part of #497.
Summary by CodeRabbit
New Features
Tests