Skip to content

Gate-pack fixtures: research + dev packs as schema'd TOML with mapping tests - #518

Merged
aarontrowbridge merged 1 commit into
mainfrom
498-gate-pack-fixtures
Aug 23, 2026
Merged

Gate-pack fixtures: research + dev packs as schema'd TOML with mapping tests#518
aarontrowbridge merged 1 commit into
mainfrom
498-gate-pack-fixtures

Conversation

@aarontrowbridge

@aarontrowbridge aarontrowbridge commented Aug 23, 2026

Copy link
Copy Markdown
Member

Closes #498.

Both gate packs as typed TOML data (packages/extension/gate-packs/): the research pack (8 gates — the five named in the issue plus ledger-currency, probe-boundary, checkout-claim from the live protocol) and the dev pack (5 gates), with the mapping-completeness suite — 57 tests green, forward+reverse checks, all floors (≥ 3 phases, ≥ 5 gates, ≥ 1 per kind, unique names, pairwise-distinct procedures), kind vocabulary enforced. Typecheck clean; smol-toml was already a devDep (no churn).

Gates as data is what the campaign layer consumes (telaio#20's mapping) and what #502's dual-harness suite polices. Part of #497.

Summary by CodeRabbit

  • New Features

    • Added development and research workflow gate packs with defined phases, responsibilities, approval gates, and completion artifacts.
    • Added handoff guidance for development hypothesis seeds and research issue seeds.
  • Tests

    • Added comprehensive validation covering gate-pack structure, required content, workflow mappings, roles, procedures, and handoff behavior.

…ith mapping-completeness tests (#498)

Gate packs as typed data, not prose: the research pack (5 phases, 8 gates,
hypothesizer/experimenter/analyzer, experiment-note + ledger-delta closing,
issue-seed handoff) extracted from the live director research protocol, and
the dev pack (3 phases, 5 gates, worktree-bound no-merge implementer,
landed-delta closing, hypothesis-seed handoff) extracted from the issue-DAG
walk. The suite in test/gate_packs.test.ts is the spec's
gate_pack_mapping_complete criterion: pack schema with kind vocabularies,
forward + reverse mapping completeness, non-triviality floors, unique gate
names, and pairwise-distinct procedures under normalized-text equality.
Parses via smol-toml (already a devDependency).
@coderabbitai

coderabbitai Bot commented Aug 23, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: a736d85a-5697-445b-8dbd-c6140b25134d

📥 Commits

Reviewing files that changed from the base of the PR and between e217adc and 74b2436.

📒 Files selected for processing (3)
  • packages/extension/gate-packs/dev.toml
  • packages/extension/gate-packs/research.toml
  • packages/extension/test/gate_packs.test.ts

📝 Walkthrough

Walkthrough

Added schema'd TOML contracts for research and development gate packs. Added Vitest specifications that validate fixture structure, mapping completeness, non-triviality, distinct procedures, protocol content, closing artifacts, and handoffs.

Changes

Gate-pack contracts

Layer / File(s) Summary
Define research and development gate packs
packages/extension/gate-packs/research.toml, packages/extension/gate-packs/dev.toml
The research pack defines five protocol phases and its gates, roles, artifact, and autodev handoff. The development pack defines three workflow phases and its gates, implementer role, landed-delta artifact, and autoresearch handoff.
Validate schema and mappings
packages/extension/test/gate_packs.test.ts
The test suite validates fixture loading, approved vocabularies, required fields, phase-gate mappings, role bindings, handoff targets, minimum counts, unique gate names, and distinct procedures.
Verify protocol-specific pack content
packages/extension/test/gate_packs.test.ts
The tests verify the required research and development phases, gate procedures, role assignments, closing artifacts, and handoff semantics.

Estimated code review effort: 3 (Moderate) | ~25 minutes

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch 498-gate-pack-fixtures

Comment @coderabbitai help to get the list of available commands.

@aarontrowbridge
aarontrowbridge marked this pull request as ready for review August 23, 2026 11:57
@aarontrowbridge
aarontrowbridge merged commit 5011b9b into main Aug 23, 2026
8 checks passed
@aarontrowbridge
aarontrowbridge deleted the 498-gate-pack-fixtures branch August 23, 2026 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Gate-pack fixtures: research + dev packs as schema'd TOML with mapping tests

1 participant