Skip to content

chore(create-plugin): Set scaffold nvmrc to Node 24 - #2830

Merged
ashharrison90 merged 1 commit into
grafana:mainfrom
alebgl77:agent/update-scaffold-node-24
Aug 21, 2026
Merged

chore(create-plugin): Set scaffold nvmrc to Node 24#2830
ashharrison90 merged 1 commit into
grafana:mainfrom
alebgl77:agent/update-scaffold-node-24

Conversation

@alebgl77

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

Updates the shared create-plugin .nvmrc template from Node 22 to Node 24 so newly generated plugins select Node 24.

The change is intentionally limited to the scaffold runtime selector. It does not change the supported engine range or workflow versions.

Which issue(s) this PR fixes:

Fixes #2827

Special notes for your reviewer:

Not run locally because Git access was unavailable in the execution environment. The change is limited to one static template file; repository CI will validate the package and scaffold matrix.

@cla-assistant

cla-assistant Bot commented Aug 15, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@cla-assistant

cla-assistant Bot commented Aug 15, 2026

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@alebgl77
alebgl77 marked this pull request as ready for review August 15, 2026 19:43
@alebgl77
alebgl77 requested a review from a team as a code owner August 15, 2026 19:43
@alebgl77
alebgl77 requested review from eledobleefe and joshhunt and removed request for a team August 15, 2026 19:43
@grafana-catalog-project-bot grafana-catalog-project-bot Bot moved this from 📬 Triage to 🔬 In review in Grafana Catalog Team Aug 17, 2026

@ashharrison90 ashharrison90 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks! 🙌

i think you'll need to:

  • sign the CLA
  • update the PR title to match convetional commit format, something like

chore(create-plugin): Set scaffold nvmrc to Node 24

@alebgl77 alebgl77 changed the title Create plugin: Set scaffold nvmrc to Node 24 chore(create-plugin): Set scaffold nvmrc to Node 24 Aug 20, 2026
@alebgl77

Copy link
Copy Markdown
Contributor Author

Thanks for the review! Title updated to conventional commit format.

The CLA is already signed, license/cla is green on this PR. The title check just needs a maintainer to approve the workflow run, since this is my first contribution from a fork.

@ashharrison90

Copy link
Copy Markdown
Contributor

Thanks for the review! Title updated to conventional commit format.

The CLA is already signed, license/cla is green on this PR. The title check just needs a maintainer to approve the workflow run, since this is my first contribution from a fork.

ah you're right, only saw the second comment saying it hadn't been signed 🤦 thanks again!

@ashharrison90
ashharrison90 merged commit e750577 into grafana:main Aug 21, 2026
29 of 30 checks passed
@github-project-automation github-project-automation Bot moved this from 🔬 In review to 🚀 Shipped in Grafana Catalog Team Aug 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🚀 Shipped

Development

Successfully merging this pull request may close these issues.

Update scaffold to set nvmrc to node 24

2 participants