feat: #1007 - Option to disable local login when OIDC is enabled - #1020
Open
DerDummePunkt wants to merge 6 commits into
Open
feat: #1007 - Option to disable local login when OIDC is enabled #1020DerDummePunkt wants to merge 6 commits into
DerDummePunkt wants to merge 6 commits into
Conversation
disable local login when OIDC is enabled - Add GOTIFY_LOCALAUTH_ENABLED, defaulting to true - Block local login and Basic Auth when disabled - Expose local auth state to the UI and hide local login flows - Skip default local admin creation when local auth is disabled - Require either local auth or OIDC at startup
jmattheis
requested changes
Aug 5, 2026
jmattheis
left a comment
jmattheis
left a comment
Member
There was a problem hiding this comment.
Looks good so far. I've some remarks and haven't tested it manually.
* use proper camelCase for `localAuth` ui flag throughout the code * added new state Enum/iota for LocalAuthDisabled and make authentication layer use it isntad of returning skipped state * do register Login handler in router, but let the handler check if local auth is enabled and inject proper context * move config check, if at least of one of localauth or oidc is enabled, to config.get scaffolding, adding futureLogs entry with error message, letting startup/serve log the future Logs the same way as for other errors
jmattheis
reviewed
Aug 6, 2026
jmattheis
left a comment
jmattheis
left a comment
Member
There was a problem hiding this comment.
I've made some small fixes.
I'll test this some more and will merge it around end of next week. (For security related stuff I want to take my time and I'm currently a bit busy).
Author
|
No worries, take your time, there's no rush |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR attempts to implement #1007
Adds configurable local authentication through GOTIFY_LOCALAUTH_ENABLED, defaults to true to preserve existing behavior.
When local authentication is disabled:
The server exits with a fatal error when both local authentication and OIDC are disabled, preventing startup without an available login method.