Change rotatePrimaryCert type to primitive boolean - #3205
Merged
Conversation
Change the rotatePrimaryCert field in CreateOrUpdateRegistrarCommand from object Boolean to primitive boolean. Since the field is initialized to default false and used as a presence-based switch without tri-state semantics, primitive boolean accurately reflects its behavior and avoids unnecessary object wrapper overhead. BUG= http://b/537308816
CydeWeys
enabled auto-merge
August 10, 2026 19:06
jicelhay
approved these changes
Aug 10, 2026
jicelhay
left a comment
jicelhay
left a comment
Collaborator
There was a problem hiding this comment.
@jicelhay reviewed 1 file and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on CydeWeys).
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the rotatePrimaryCert field in CreateOrUpdateRegistrarCommand from object Boolean to primitive boolean. Since the field is initialized to default false and used as a presence-based switch without tri-state semantics, primitive boolean accurately reflects its behavior and avoids unnecessary object wrapper overhead.
BUG= http://b/537308816
This change is