Test database should use real locale configs - #3204
Merged
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
weiminyu
force-pushed
the
assert-db-encoding
branch
from
August 7, 2026 21:59
b6b7911 to
7ca4ed9
Compare
weiminyu
commented
Aug 7, 2026
weiminyu
left a comment
weiminyu
left a comment
Collaborator
Author
There was a problem hiding this comment.
@weiminyu resolved 1 discussion.
Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on gbrodman).
gbrodman
approved these changes
Aug 10, 2026
gbrodman
left a comment
gbrodman
left a comment
Collaborator
There was a problem hiding this comment.
@gbrodman reviewed 2 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on weiminyu).
Use the real locale configs from Cloud SQL when creating postgres database using docker.
weiminyu
force-pushed
the
assert-db-encoding
branch
from
August 11, 2026 15:49
7ca4ed9 to
628e652
Compare
weiminyu
enabled auto-merge
August 11, 2026 15:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the real locale configs from Cloud SQL when creating postgres database using docker.
This change is