Skip to content

Don't end ext_wrappers.gen.inc macros with a backslash-newline - #2040

Merged
dsnopek merged 1 commit into
godotengine:masterfrom
Faless:fix/backslash-newline
Aug 11, 2026
Merged

Don't end ext_wrappers.gen.inc macros with a backslash-newline#2040
dsnopek merged 1 commit into
godotengine:masterfrom
Faless:fix/backslash-newline

Conversation

@Faless

@Faless Faless commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Fixes warning when including ext_wrappers.gen.inc:

godot-cpp/gen/include/godot_cpp/core/ext_wrappers.gen.inc:181:148: warning: backslash-newline at end of file

@Faless
Faless requested a review from a team as a code owner August 9, 2026 07:46
@Faless Faless added the bug This has been identified as a bug label Aug 9, 2026
@dsnopek

dsnopek commented Aug 10, 2026

Copy link
Copy Markdown
Collaborator

Thanks!

However, I'm not sure this is right fix

All the #define's look like:

#define MODBIND0( m_name) \
virtual void _##m_name()  override; \

That second line probably shouldn't even end with a \ in the first place. Could we just remove it in the s variable at the start of generate_mod_version()?

Fixes warning when including ext_wrappers.gen.inc:

godot-cpp/gen/include/godot_cpp/core/ext_wrappers.gen.inc:181:148: warning: backslash-newline at end of file
@Faless
Faless force-pushed the fix/backslash-newline branch from cf7d3ef to f44bed5 Compare August 10, 2026 14:22
@Faless

Faless commented Aug 10, 2026

Copy link
Copy Markdown
Contributor Author

That second line probably shouldn't even end with a \ in the first place. Could we just remove it in the s variable at the start of generate_mod_version()?

Ah, indeed, that is not needed, I was too focused on the fix that I didn't think of it 😅 .

Fixed, thanks!

@Faless Faless changed the title Don't end ext_wrappers.gen.inc with a backslash-newline Don't end ext_wrappers.gen.inc macros with a backslash-newline Aug 10, 2026

@dsnopek dsnopek left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM :-)

@dsnopek
dsnopek merged commit 65df905 into godotengine:master Aug 11, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug This has been identified as a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants