Skip to content

Upgrade transitive js-yaml dependencies - #4497

Open
cklin wants to merge 2 commits into
mainfrom
cklin/upgrade-js-yaml
Open

Upgrade transitive js-yaml dependencies#4497
cklin wants to merge 2 commits into
mainfrom
cklin/upgrade-js-yaml

Conversation

@cklin

@cklin cklin commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Summary

Upgrade the transitive js-yaml dependencies in the VS Code extension:

  • 3.14.13.15.1
  • 4.3.04.3.1
  • Eliminate the strict 4.1.1 dependency by upgrading markdownlint-cli2 from 0.22.1 to 0.23.2

The markdownlint-cli2 upgrade removes its exact dependency on js-yaml@4.1.1, allowing the remaining 4.x dependencies to resolve to 4.3.1.

Testing

  • Ran the Markdown linter
  • Ran a targeted unit test through Jest

Copilot AI review requested due to automatic review settings August 3, 2026 20:11

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates transitive js-yaml dependencies and removes the strict 4.1.1 dependency.

Changes:

  • Upgrades markdownlint-cli2 to 0.23.2.
  • Refreshes related Markdown tooling and js-yaml lockfile entries.
Show a summary per file
File Description
extensions/ql-vscode/package.json Updates the Markdown linter dependency.
extensions/ql-vscode/package-lock.json Records updated transitive dependencies.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Files not reviewed (1)
  • extensions/ql-vscode/package-lock.json: Generated file
  • Files reviewed: 1/2 changed files
  • Comments generated: 1
  • Review effort level: Balanced

Comment thread extensions/ql-vscode/package-lock.json
cklin and others added 2 commits August 3, 2026 13:19
This upgrade eliminates the strict js-yaml 4.1.1 dependency.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: e49b75d8-25b6-4b16-9797-6f31ac6599f8
Upgrade js-yaml 3.14.1 to 3.15.1 and 4.3.0 to 4.3.1.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: e49b75d8-25b6-4b16-9797-6f31ac6599f8
Copilot AI review requested due to automatic review settings August 3, 2026 20:20
@cklin
cklin force-pushed the cklin/upgrade-js-yaml branch from bfe239d to b6954b9 Compare August 3, 2026 20:20

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

Files not reviewed (1)
  • extensions/ql-vscode/package-lock.json: Generated file
  • Files reviewed: 1/2 changed files
  • Comments generated: 0 new
  • Review effort level: Balanced

@cklin
cklin marked this pull request as ready for review August 3, 2026 20:45
@cklin
cklin requested a review from a team as a code owner August 3, 2026 20:45
@cklin
cklin requested a review from d10c August 3, 2026 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants